fix: change status code from 307 to 302 by default for GET request

Author: kenjis

system/HTTP/ResponseTrait.php

@@ -516,9 +516,14 @@ public function redirect(string $uri, string $method = 'auto', ?int $code = null
                 isset($_SERVER['SERVER_PROTOCOL'], $_SERVER['REQUEST_METHOD'])
                 && $this->getProtocolVersion() >= 1.1
             ) {
-                $code = (in_array($_SERVER['REQUEST_METHOD'], ['POST', 'PUT', 'DELETE'], true))
-                    ? 303 // reference: https://en.wikipedia.org/wiki/Post/Redirect/Get
-                    : 307;
+                if ($_SERVER['REQUEST_METHOD'] === 'GET') {
+                    $code = 302;
+                } elseif (in_array($_SERVER['REQUEST_METHOD'], ['POST', 'PUT', 'DELETE'], true)) {
+                    // reference: https://en.wikipedia.org/wiki/Post/Redirect/Get
+                    $code = 303;
+                } else {
+                    $code = 307;
+                }
             }
         }
 

tests/system/HTTP/ResponseTest.php

@@ -294,7 +294,7 @@ public function testRedirect(
     public function provideForRedirect()
     {
         yield from [
-            ['Apache/2.4.17', 'HTTP/1.1', 'GET', null, 307],
+            ['Apache/2.4.17', 'HTTP/1.1', 'GET', null, 302],
             ['Apache/2.4.17', 'HTTP/1.1', 'GET', 307, 307],
             ['Apache/2.4.17', 'HTTP/1.1', 'GET', 302, 302],
             ['Apache/2.4.17', 'HTTP/1.1', 'POST', null, 303],
@@ -519,7 +519,7 @@ public function testMisbehaving()
         $response->getStatusCode();
     }
 
-    public function testTemporaryRedirect11()
+    public function testTemporaryRedirectHTTP11()
     {
         $_SERVER['SERVER_PROTOCOL'] = 'HTTP/1.1';
         $_SERVER['REQUEST_METHOD']  = 'POST';
@@ -531,7 +531,7 @@ public function testTemporaryRedirect11()
         $this->assertSame(303, $response->getStatusCode());
     }
 
-    public function testTemporaryRedirectGet11()
+    public function testTemporaryRedirectGetHTTP11()
     {
         $_SERVER['SERVER_PROTOCOL'] = 'HTTP/1.1';
         $_SERVER['REQUEST_METHOD']  = 'GET';
@@ -540,7 +540,7 @@ public function testTemporaryRedirectGet11()
         $response->setProtocolVersion('HTTP/1.1');
         $response->redirect('/foo');
 
-        $this->assertSame(307, $response->getStatusCode());
+        $this->assertSame(302, $response->getStatusCode());
     }
 
     // Make sure cookies are set by RedirectResponse this way