Skip to content

Commit d0b9868

Browse files
committed
refactor: rename cachePage() to make()
1 parent b2afd71 commit d0b9868

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

system/Cache/ResponseCache.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public function generateCacheKey($request): string
7474
*
7575
* @params int $ttl time to live in seconds.
7676
*/
77-
public function cachePage($request, ResponseInterface $response, int $ttl): bool
77+
public function make($request, ResponseInterface $response, int $ttl): bool
7878
{
7979
$headers = [];
8080

system/CodeIgniter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ protected function handleRequest(?RouteCollectionInterface $routes, Cache $cache
526526
// so that we can have live speed updates along the way.
527527
// Must be run after filters to preserve the Response headers.
528528
if (static::$cacheTTL > 0) {
529-
$this->pageCache->cachePage($this->request, $this->response, static::$cacheTTL);
529+
$this->pageCache->make($this->request, $this->response, static::$cacheTTL);
530530
}
531531

532532
// Update the performance metrics

tests/system/Cache/ResponseCacheTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public function testCachePageIncomingRequest()
101101
$response->setHeader('ETag', 'abcd1234');
102102
$response->setBody('The response body.');
103103

104-
$return = $pageCache->cachePage($request, $response, 300);
104+
$return = $pageCache->make($request, $response, 300);
105105

106106
$this->assertTrue($return);
107107

@@ -141,7 +141,7 @@ public function testCachePageIncomingRequestWithCacheQueryString()
141141
$response->setHeader('ETag', 'abcd1234');
142142
$response->setBody('The response body.');
143143

144-
$return = $pageCache->cachePage($request, $response, 300);
144+
$return = $pageCache->make($request, $response, 300);
145145

146146
$this->assertTrue($return);
147147

@@ -176,7 +176,7 @@ public function testCachePageCLIRequest()
176176
$response = new Response($this->appConfig);
177177
$response->setBody('The response body.');
178178

179-
$return = $pageCache->cachePage($request, $response, 300);
179+
$return = $pageCache->make($request, $response, 300);
180180

181181
$this->assertTrue($return);
182182

@@ -210,7 +210,7 @@ public function testUnserializeError()
210210
$response->setHeader('ETag', 'abcd1234');
211211
$response->setBody('The response body.');
212212

213-
$pageCache->cachePage($request, $response, 300);
213+
$pageCache->make($request, $response, 300);
214214

215215
$cacheKey = $pageCache->generateCacheKey($request);
216216

@@ -236,7 +236,7 @@ public function testInvalidCacheError()
236236
$response->setHeader('ETag', 'abcd1234');
237237
$response->setBody('The response body.');
238238

239-
$pageCache->cachePage($request, $response, 300);
239+
$pageCache->make($request, $response, 300);
240240

241241
$cacheKey = $pageCache->generateCacheKey($request);
242242

0 commit comments

Comments
 (0)