refactor: fix function.alreadyNarrowedType errors (#9518)

Author: paulbalandan

system/HTTP/Files/FileCollection.php

@@ -253,7 +253,7 @@ protected function getValueDotNotationSyntax(array $index, array $value)
     {
         $currentIndex = array_shift($index);
 
-        if (isset($currentIndex) && is_array($index) && $index !== [] && array_key_exists($currentIndex, $value) && is_array($value[$currentIndex])) {
+        if (isset($currentIndex) && $index !== [] && array_key_exists($currentIndex, $value) && is_array($value[$currentIndex])) {
             return $this->getValueDotNotationSyntax($index, $value[$currentIndex]);
         }
 

system/Test/DOMParser.php

@@ -233,10 +233,8 @@ protected function doXPath(?string $search, string $element, array $paths = [])
 
         // $paths might contain a number of different
         // ready to go xpath portions to tack on.
-        if ($paths !== [] && is_array($paths)) {
-            foreach ($paths as $extra) {
-                $path .= $extra;
-            }
+        foreach ($paths as $extra) {
+            $path .= $extra;
         }
 
         if ($search !== null) {

utils/phpstan-baseline/function.alreadyNarrowedType.neon

@@ -1,4 +1,4 @@
-# total 3589 errors
+# total 3587 errors
 includes:
     - argument.type.neon
     - assign.propertyType.neon
@@ -11,7 +11,6 @@ includes:
     - deadCode.unreachable.neon
     - empty.notAllowed.neon
     - empty.property.neon
-    - function.alreadyNarrowedType.neon
     - generator.valueType.neon
     - isset.property.neon
     - method.alreadyNarrowedType.neon