Skip to content

Commit b0cf1f3

Browse files
samsonasiksamsonasik
authored
Merge pull request #4759 from samsonasik/apply-rector-var-constant-comment
[Rector] Apply Rector: VarConstantCommentRector
2 parents 638a5d7 + 52a1823 commit b0cf1f3

File tree

10 files changed

+281
-62
lines changed

10 files changed

+281
-62
lines changed

‎rector.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
use Rector\CodeQuality\Rector\Return_\SimplifyUselessVariableRector;
1313
use Rector\CodeQuality\Rector\Ternary\UnnecessaryTernaryExpressionRector;
1414
use Rector\CodeQualityStrict\Rector\Variable\MoveVariableDeclarationNearReferenceRector;
15+
use Rector\CodingStyle\Rector\ClassConst\VarConstantCommentRector;
1516
use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
1617
use Rector\Core\Configuration\Option;
1718
use Rector\Core\ValueObject\PhpVersion;
@@ -92,4 +93,5 @@
9293
$services->set(TernaryToNullCoalescingRector::class);
9394
$services->set(ListToArrayDestructRector::class);
9495
$services->set(MoveVariableDeclarationNearReferenceRector::class);
96+
$services->set(VarConstantCommentRector::class);
9597
};

‎system/Cache/Handlers/BaseHandler.php‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,15 @@ abstract class BaseHandler implements CacheInterface
2424
/**
2525
* Reserved characters that cannot be used in a key or tag.
2626
* From https://github.com/symfony/cache-contracts/blob/c0446463729b89dd4fa62e9aeecc80287323615d/ItemInterface.php#L43
27+
*
28+
* @var string
2729
*/
2830
public const RESERVED_CHARACTERS = '{}()/\@:';
2931

3032
/**
3133
* Maximum key length.
34+
*
35+
* @var int
3236
*/
3337
public const MAX_KEY_LENGTH = PHP_INT_MAX;
3438

‎system/Cache/Handlers/FileHandler.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ class FileHandler extends BaseHandler
2222
{
2323
/**
2424
* Maximum key length.
25+
*
26+
* @var int
2527
*/
2628
public const MAX_KEY_LENGTH = 255;
2729

‎system/CodeIgniter.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ class CodeIgniter
4343
{
4444
/**
4545
* The current version of CodeIgniter Framework
46+
*
47+
* @var string
4648
*/
4749
const CI_VERSION = '4.1.2';
4850

‎system/Cookie/CookieInterface.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ interface CookieInterface
2222
* Cookies will be sent in all contexts, i.e in responses to both
2323
* first-party and cross-origin requests. If `SameSite=None` is set,
2424
* the cookie `Secure` attribute must also be set (or the cookie will be blocked).
25+
*
26+
* @var string
2527
*/
2628
public const SAMESITE_NONE = 'none';
2729

‎system/HTTP/ResponseInterface.php‎

Lines changed: 253 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -36,77 +36,271 @@ interface ResponseInterface
3636
/**
3737
* Constants for status codes.
3838
* From https://en.wikipedia.org/wiki/List_of_HTTP_status_codes
39+
*
40+
* @var int
3941
*/
4042
// Informational
41-
const HTTP_CONTINUE = 100;
43+
const HTTP_CONTINUE = 100;
44+
/**
45+
* @var int
46+
*/
4247
const HTTP_SWITCHING_PROTOCOLS = 101;
43-
const HTTP_PROCESSING = 102;
44-
const HTTP_EARLY_HINTS = 103;
48+
/**
49+
* @var int
50+
*/
51+
const HTTP_PROCESSING = 102;
52+
/**
53+
* @var int
54+
*/
55+
const HTTP_EARLY_HINTS = 103;
4556
// Success
46-
const HTTP_OK = 200;
47-
const HTTP_CREATED = 201;
48-
const HTTP_ACCEPTED = 202;
57+
/**
58+
* @var int
59+
*/
60+
const HTTP_OK = 200;
61+
/**
62+
* @var int
63+
*/
64+
const HTTP_CREATED = 201;
65+
/**
66+
* @var int
67+
*/
68+
const HTTP_ACCEPTED = 202;
69+
/**
70+
* @var int
71+
*/
4972
const HTTP_NONAUTHORITATIVE_INFORMATION = 203;
50-
const HTTP_NO_CONTENT = 204;
51-
const HTTP_RESET_CONTENT = 205;
52-
const HTTP_PARTIAL_CONTENT = 206;
53-
const HTTP_MULTI_STATUS = 207;
54-
const HTTP_ALREADY_REPORTED = 208;
55-
const HTTP_IM_USED = 226;
73+
/**
74+
* @var int
75+
*/
76+
const HTTP_NO_CONTENT = 204;
77+
/**
78+
* @var int
79+
*/
80+
const HTTP_RESET_CONTENT = 205;
81+
/**
82+
* @var int
83+
*/
84+
const HTTP_PARTIAL_CONTENT = 206;
85+
/**
86+
* @var int
87+
*/
88+
const HTTP_MULTI_STATUS = 207;
89+
/**
90+
* @var int
91+
*/
92+
const HTTP_ALREADY_REPORTED = 208;
93+
/**
94+
* @var int
95+
*/
96+
const HTTP_IM_USED = 226;
5697
// Redirection
57-
const HTTP_MULTIPLE_CHOICES = 300;
58-
const HTTP_MOVED_PERMANENTLY = 301;
59-
const HTTP_FOUND = 302;
60-
const HTTP_SEE_OTHER = 303;
61-
const HTTP_NOT_MODIFIED = 304;
62-
const HTTP_USE_PROXY = 305;
63-
const HTTP_SWITCH_PROXY = 306;
98+
/**
99+
* @var int
100+
*/
101+
const HTTP_MULTIPLE_CHOICES = 300;
102+
/**
103+
* @var int
104+
*/
105+
const HTTP_MOVED_PERMANENTLY = 301;
106+
/**
107+
* @var int
108+
*/
109+
const HTTP_FOUND = 302;
110+
/**
111+
* @var int
112+
*/
113+
const HTTP_SEE_OTHER = 303;
114+
/**
115+
* @var int
116+
*/
117+
const HTTP_NOT_MODIFIED = 304;
118+
/**
119+
* @var int
120+
*/
121+
const HTTP_USE_PROXY = 305;
122+
/**
123+
* @var int
124+
*/
125+
const HTTP_SWITCH_PROXY = 306;
126+
/**
127+
* @var int
128+
*/
64129
const HTTP_TEMPORARY_REDIRECT = 307;
130+
/**
131+
* @var int
132+
*/
65133
const HTTP_PERMANENT_REDIRECT = 308;
66134
// Client Error
67-
const HTTP_BAD_REQUEST = 400;
68-
const HTTP_UNAUTHORIZED = 401;
69-
const HTTP_PAYMENT_REQUIRED = 402;
70-
const HTTP_FORBIDDEN = 403;
71-
const HTTP_NOT_FOUND = 404;
72-
const HTTP_METHOD_NOT_ALLOWED = 405;
73-
const HTTP_NOT_ACCEPTABLE = 406;
74-
const HTTP_PROXY_AUTHENTICATION_REQUIRED = 407;
75-
const HTTP_REQUEST_TIMEOUT = 408;
76-
const HTTP_CONFLICT = 409;
77-
const HTTP_GONE = 410;
78-
const HTTP_LENGTH_REQUIRED = 411;
79-
const HTTP_PRECONDITION_FAILED = 412;
80-
const HTTP_PAYLOAD_TOO_LARGE = 413;
81-
const HTTP_URI_TOO_LONG = 414;
82-
const HTTP_UNSUPPORTED_MEDIA_TYPE = 415;
83-
const HTTP_RANGE_NOT_SATISFIABLE = 416;
84-
const HTTP_EXPECTATION_FAILED = 417;
85-
const HTTP_IM_A_TEAPOT = 418;
86-
const HTTP_MISDIRECTED_REQUEST = 421;
87-
const HTTP_UNPROCESSABLE_ENTITY = 422;
88-
const HTTP_LOCKED = 423;
89-
const HTTP_FAILED_DEPENDENCY = 424;
90-
const HTTP_TOO_EARLY = 425;
91-
const HTTP_UPGRADE_REQUIRED = 426;
92-
const HTTP_PRECONDITION_REQUIRED = 428;
93-
const HTTP_TOO_MANY_REQUESTS = 429;
135+
/**
136+
* @var int
137+
*/
138+
const HTTP_BAD_REQUEST = 400;
139+
/**
140+
* @var int
141+
*/
142+
const HTTP_UNAUTHORIZED = 401;
143+
/**
144+
* @var int
145+
*/
146+
const HTTP_PAYMENT_REQUIRED = 402;
147+
/**
148+
* @var int
149+
*/
150+
const HTTP_FORBIDDEN = 403;
151+
/**
152+
* @var int
153+
*/
154+
const HTTP_NOT_FOUND = 404;
155+
/**
156+
* @var int
157+
*/
158+
const HTTP_METHOD_NOT_ALLOWED = 405;
159+
/**
160+
* @var int
161+
*/
162+
const HTTP_NOT_ACCEPTABLE = 406;
163+
/**
164+
* @var int
165+
*/
166+
const HTTP_PROXY_AUTHENTICATION_REQUIRED = 407;
167+
/**
168+
* @var int
169+
*/
170+
const HTTP_REQUEST_TIMEOUT = 408;
171+
/**
172+
* @var int
173+
*/
174+
const HTTP_CONFLICT = 409;
175+
/**
176+
* @var int
177+
*/
178+
const HTTP_GONE = 410;
179+
/**
180+
* @var int
181+
*/
182+
const HTTP_LENGTH_REQUIRED = 411;
183+
/**
184+
* @var int
185+
*/
186+
const HTTP_PRECONDITION_FAILED = 412;
187+
/**
188+
* @var int
189+
*/
190+
const HTTP_PAYLOAD_TOO_LARGE = 413;
191+
/**
192+
* @var int
193+
*/
194+
const HTTP_URI_TOO_LONG = 414;
195+
/**
196+
* @var int
197+
*/
198+
const HTTP_UNSUPPORTED_MEDIA_TYPE = 415;
199+
/**
200+
* @var int
201+
*/
202+
const HTTP_RANGE_NOT_SATISFIABLE = 416;
203+
/**
204+
* @var int
205+
*/
206+
const HTTP_EXPECTATION_FAILED = 417;
207+
/**
208+
* @var int
209+
*/
210+
const HTTP_IM_A_TEAPOT = 418;
211+
/**
212+
* @var int
213+
*/
214+
const HTTP_MISDIRECTED_REQUEST = 421;
215+
/**
216+
* @var int
217+
*/
218+
const HTTP_UNPROCESSABLE_ENTITY = 422;
219+
/**
220+
* @var int
221+
*/
222+
const HTTP_LOCKED = 423;
223+
/**
224+
* @var int
225+
*/
226+
const HTTP_FAILED_DEPENDENCY = 424;
227+
/**
228+
* @var int
229+
*/
230+
const HTTP_TOO_EARLY = 425;
231+
/**
232+
* @var int
233+
*/
234+
const HTTP_UPGRADE_REQUIRED = 426;
235+
/**
236+
* @var int
237+
*/
238+
const HTTP_PRECONDITION_REQUIRED = 428;
239+
/**
240+
* @var int
241+
*/
242+
const HTTP_TOO_MANY_REQUESTS = 429;
243+
/**
244+
* @var int
245+
*/
94246
const HTTP_REQUEST_HEADER_FIELDS_TOO_LARGE = 431;
95-
const HTTP_UNAVAILABLE_FOR_LEGAL_REASONS = 451;
96-
const HTTP_CLIENT_CLOSED_REQUEST = 499;
247+
/**
248+
* @var int
249+
*/
250+
const HTTP_UNAVAILABLE_FOR_LEGAL_REASONS = 451;
251+
/**
252+
* @var int
253+
*/
254+
const HTTP_CLIENT_CLOSED_REQUEST = 499;
97255
// Server Error
98-
const HTTP_INTERNAL_SERVER_ERROR = 500;
99-
const HTTP_NOT_IMPLEMENTED = 501;
100-
const HTTP_BAD_GATEWAY = 502;
101-
const HTTP_SERVICE_UNAVAILABLE = 503;
102-
const HTTP_GATEWAY_TIMEOUT = 504;
103-
const HTTP_HTTP_VERSION_NOT_SUPPORTED = 505;
104-
const HTTP_VARIANT_ALSO_NEGOTIATES = 506;
105-
const HTTP_INSUFFICIENT_STORAGE = 507;
106-
const HTTP_LOOP_DETECTED = 508;
107-
const HTTP_NOT_EXTENDED = 510;
256+
/**
257+
* @var int
258+
*/
259+
const HTTP_INTERNAL_SERVER_ERROR = 500;
260+
/**
261+
* @var int
262+
*/
263+
const HTTP_NOT_IMPLEMENTED = 501;
264+
/**
265+
* @var int
266+
*/
267+
const HTTP_BAD_GATEWAY = 502;
268+
/**
269+
* @var int
270+
*/
271+
const HTTP_SERVICE_UNAVAILABLE = 503;
272+
/**
273+
* @var int
274+
*/
275+
const HTTP_GATEWAY_TIMEOUT = 504;
276+
/**
277+
* @var int
278+
*/
279+
const HTTP_HTTP_VERSION_NOT_SUPPORTED = 505;
280+
/**
281+
* @var int
282+
*/
283+
const HTTP_VARIANT_ALSO_NEGOTIATES = 506;
284+
/**
285+
* @var int
286+
*/
287+
const HTTP_INSUFFICIENT_STORAGE = 507;
288+
/**
289+
* @var int
290+
*/
291+
const HTTP_LOOP_DETECTED = 508;
292+
/**
293+
* @var int
294+
*/
295+
const HTTP_NOT_EXTENDED = 510;
296+
/**
297+
* @var int
298+
*/
108299
const HTTP_NETWORK_AUTHENTICATION_REQUIRED = 511;
109-
const HTTP_NETWORK_CONNECT_TIMEOUT_ERROR = 599;
300+
/**
301+
* @var int
302+
*/
303+
const HTTP_NETWORK_CONNECT_TIMEOUT_ERROR = 599;
110304

111305
/**
112306
* Gets the response status code.

0 commit comments

Comments
 (0)