Merge pull request #906 from natanfelles/cli_validation_session

lonnieezell · web-flow · commit a6fd7a135e22 · 2018-01-15T22:53:11.000-06:00
Avoid the session usage if is_cli() in Validation getErrors()
diff --git a/system/Validation/Validation.php b/system/Validation/Validation.php
@@ -613,7 +613,7 @@ public function getErrors(): array
 		// If we already have errors, we'll use those.
 		// If we don't, check the session to see if any were
 		// passed along from a redirect_with_input request.
-		if (empty($this->errors))
+		if (empty($this->errors) && ! is_cli())
 		{
 			// Start up the session if it's not already
 			if ( ! isset($_SESSION))

Original file line number	Diff line number	Diff line change
`@@ -613,7 +613,7 @@ public function getErrors(): array`
`613`	`613`	`// If we already have errors, we'll use those.`
`614`	`614`	`// If we don't, check the session to see if any were`
`615`	`615`	`// passed along from a redirect_with_input request.`
`616`		`- if (empty($this->errors))`
	`616`	`+ if (empty($this->errors) && ! is_cli())`
`617`	`617`	`{`
`618`	`618`	`// Start up the session if it's not already`
`619`	`619`	`if ( ! isset($_SESSION))`