test: fix missingType.return errors (#9542)

Author: paulbalandan

system/Config/Factories.php

@@ -513,6 +513,12 @@ public static function getBasename(string $alias): string
     /**
      * Gets component data for caching.
      *
+     * @return array{
+     *   options: array<string, bool|string|null>,
+     *   aliases: array<string, class-string>,
+     *   instances: array<class-string, object>,
+     * }
+     *
      * @internal For caching only
      */
     public static function getComponentInstances(string $component): array

system/Test/FilterTestTrait.php

@@ -120,7 +120,7 @@ protected function setUpFilterTestTrait(): void
      * @param FilterInterface|string $filter   The filter instance, class, or alias
      * @param string                 $position "before" or "after"
      *
-     * @phpstan-return Closure(list<string>|null=): mixed
+     * @return Closure(list<string>|null=): mixed
      */
     protected function getFilterCaller($filter, string $position): Closure
     {
@@ -268,6 +268,8 @@ protected function assertFilter(string $route, string $position, string $alias):
      * @param string $route    The route to test
      * @param string $position "before" or "after"
      * @param string $alias    Alias for the anticipated filter
+     *
+     * @return void
      */
     protected function assertNotFilter(string $route, string $position, string $alias)
     {
@@ -286,6 +288,8 @@ protected function assertNotFilter(string $route, string $position, string $alia
      *
      * @param string $route    The route to test
      * @param string $position "before" or "after"
+     *
+     * @return void
      */
     protected function assertHasFilters(string $route, string $position)
     {
@@ -303,6 +307,8 @@ protected function assertHasFilters(string $route, string $position)
      *
      * @param string $route    The route to test
      * @param string $position "before" or "after"
+     *
+     * @return void
      */
     protected function assertNotHasFilters(string $route, string $position)
     {

system/Validation/Validation.php

@@ -23,7 +23,6 @@
 use CodeIgniter\HTTP\RequestInterface;
 use CodeIgniter\Validation\Exceptions\ValidationException;
 use CodeIgniter\View\RendererInterface;
-use Config\Validation as ValidationConfig;
 
 /**
  * Validator
@@ -96,7 +95,7 @@ class Validation implements ValidationInterface
     /**
      * Our configuration.
      *
-     * @var ValidationConfig
+     * @var object{ruleSets: list<class-string>}
      */
     protected $config;
 
@@ -110,7 +109,7 @@ class Validation implements ValidationInterface
     /**
      * Validation constructor.
      *
-     * @param ValidationConfig $config
+     * @param object{ruleSets: list<class-string>} $config
      */
     public function __construct($config, RendererInterface $view)
     {

tests/system/API/ResponseTraitTest.php

@@ -108,7 +108,7 @@ private function createRequestAndResponse(string $routePath = '', array $userHea
         }
     }
 
-    protected function makeController(string $routePath = '', array $userHeaders = [])
+    protected function makeController(string $routePath = '', array $userHeaders = []): object
     {
         $this->createRequestAndResponse($routePath, $userHeaders);
 
@@ -659,7 +659,7 @@ public function testXMLResponseFormat(): void
         $this->assertSame($xmlFormatter->format($data), $this->response->getXML());
     }
 
-    private function invoke(object $controller, string $method, array $args = [])
+    private function invoke(object $controller, string $method, array $args = []): object
     {
         $method = self::getPrivateMethodInvoker($controller, $method);
 

tests/system/Cache/Handlers/FileHandlerTest.php

@@ -30,7 +30,10 @@ final class FileHandlerTest extends AbstractHandlerTestCase
     private static string $directory = 'FileHandler';
     private Cache $config;
 
-    private static function getKeyArray()
+    /**
+     * @return list<string>
+     */
+    private static function getKeyArray(): array
     {
         return [
             self::$key1,
@@ -328,25 +331,16 @@ public function testSaveMode(int $int, string $string): void
         $this->assertSame($string, $mode);
     }
 
+    /**
+     * @return iterable<int, array{int, numeric-string}>
+     */
     public static function provideSaveMode(): iterable
     {
         return [
-            [
-                0640,
-                '640',
-            ],
-            [
-                0600,
-                '600',
-            ],
-            [
-                0660,
-                '660',
-            ],
-            [
-                0777,
-                '777',
-            ],
+            [0640, '640'],
+            [0600, '600'],
+            [0660, '660'],
+            [0777, '777'],
         ];
     }
 
@@ -382,14 +376,19 @@ public function __construct()
         $this->config->file['storePath'] .= self::$directory;
 
         parent::__construct($this->config);
+
+        helper('filesystem');
     }
 
-    public function getFileInfoTest()
+    /**
+     * @return array<string, bool|int|string>|null
+     */
+    public function getFileInfoTest(): ?array
     {
         $tmpHandle = tmpfile();
         stream_get_meta_data($tmpHandle);
 
-        return $this->getFileInfo(stream_get_meta_data($tmpHandle)['uri'], [
+        return get_file_info(stream_get_meta_data($tmpHandle)['uri'], [
             'name',
             'server_path',
             'size',

tests/system/Cache/Handlers/MemcachedHandlerTest.php

@@ -25,7 +25,10 @@
 #[Group('CacheLive')]
 final class MemcachedHandlerTest extends AbstractHandlerTestCase
 {
-    private static function getKeyArray()
+    /**
+     * @return list<string>
+     */
+    private static function getKeyArray(): array
     {
         return [
             self::$key1,

tests/system/Cache/Handlers/PredisHandlerTest.php

@@ -26,7 +26,10 @@ final class PredisHandlerTest extends AbstractHandlerTestCase
 {
     private Cache $config;
 
-    private static function getKeyArray()
+    /**
+     * @return list<string>
+     */
+    private static function getKeyArray(): array
     {
         return [
             self::$key1,

tests/system/Cache/Handlers/RedisHandlerTest.php

@@ -28,7 +28,10 @@ final class RedisHandlerTest extends AbstractHandlerTestCase
 {
     private Cache $config;
 
-    private static function getKeyArray()
+    /**
+     * @return list<string>
+     */
+    private static function getKeyArray(): array
     {
         return [
             self::$key1,

tests/system/Commands/CreateDatabaseTest.php

@@ -64,7 +64,7 @@ private function dropDatabase(): void
         }
     }
 
-    protected function getBuffer()
+    protected function getBuffer(): string
     {
         return $this->getStreamFilterBuffer();
     }

tests/system/Commands/FilterCheckTest.php

@@ -37,7 +37,7 @@ protected function tearDown(): void
         parent::tearDown();
     }
 
-    protected function getBuffer()
+    protected function getBuffer(): string
     {
         return $this->getStreamFilterBuffer();
     }