refactor: extract method

Author: kenjis

system/Filters/Filters.php

@@ -237,23 +237,9 @@ private function runBefore(array $filterClassList)
             $className = $filterClassInfo[0];
             $arguments = ($filterClassInfo[1] === []) ? null : $filterClassInfo[1];
 
-            if (isset($this->filterClassInstances[$className])) {
-                $class = $this->filterClassInstances[$className];
-            } else {
-                $class = new $className();
-
-                if (! $class instanceof FilterInterface) {
-                    throw FilterException::forIncorrectInterface($class::class);
-                }
-
-                $this->filterClassInstances[$className] = $class;
-            }
-
-            if (! $class instanceof FilterInterface) {
-                throw FilterException::forIncorrectInterface($class::class);
-            }
+            $instance = $this->createFilter($className);
 
-            $result = $class->before($this->request, $arguments);
+            $result = $instance->before($this->request, $arguments);
 
             if ($result instanceof RequestInterface) {
                 $this->request = $result;
@@ -288,19 +274,9 @@ private function runAfter(array $filterClassList): ResponseInterface
             $className = $filterClassInfo[0];
             $arguments = ($filterClassInfo[1] === []) ? null : $filterClassInfo[1];
 
-            if (isset($this->filterClassInstances[$className])) {
-                $class = $this->filterClassInstances[$className];
-            } else {
-                $class = new $className();
-
-                if (! $class instanceof FilterInterface) {
-                    throw FilterException::forIncorrectInterface($class::class);
-                }
-
-                $this->filterClassInstances[$className] = $class;
-            }
+            $instance = $this->createFilter($className);
 
-            $result = $class->after($this->request, $this->response, $arguments);
+            $result = $instance->after($this->request, $this->response, $arguments);
 
             if ($result instanceof ResponseInterface) {
                 $this->response = $result;
@@ -312,6 +288,26 @@ private function runAfter(array $filterClassList): ResponseInterface
         return $this->response;
     }
 
+    /**
+     * @param class-string $className
+     */
+    private function createFilter(string $className): FilterInterface
+    {
+        if (isset($this->filterClassInstances[$className])) {
+            return $this->filterClassInstances[$className];
+        }
+
+        $instance = new $className();
+
+        if (! $instance instanceof FilterInterface) {
+            throw FilterException::forIncorrectInterface($instance::class);
+        }
+
+        $this->filterClassInstances[$className] = $instance;
+
+        return $instance;
+    }
+
     /**
      * Runs "Required Filters" for the specified position.
      *