Merge pull request #5653 from kenjis/refactor-CLI-Incomming-Request

refactor: isCLI() in CLIRequest and IncomingRequest

Author: samsonasik

system/HTTP/CLIRequest.php

@@ -195,6 +195,6 @@ protected function parseCommand()
      */
     public function isCLI(): bool
     {
-        return is_cli();
+        return true;
     }
 }

system/HTTP/IncomingRequest.php

@@ -347,7 +347,7 @@ public function negotiate(string $type, array $supported, bool $strictMatch = fa
      */
     public function isCLI(): bool
     {
-        return is_cli();
+        return false;
     }
 
     /**

tests/system/HTTP/IncomingRequestTest.php

@@ -439,8 +439,7 @@ public function testCanGrabGetRawInput()
 
     public function testIsCLI()
     {
-        // this should be the case in unit testing
-        $this->assertTrue($this->request->isCLI());
+        $this->assertFalse($this->request->isCLI());
     }
 
     public function testIsAJAX()