refactor: fix param types

Author: kenjis

system/HTTP/Files/FileCollection.php

@@ -187,7 +187,7 @@ protected function createFileObject(array $array)
             $array['tmp_name'] ?? null,
             $array['name'] ?? null,
             $array['type'] ?? null,
-            $array['size'] ?? null,
+            ($array['size'] ?? null) === null ? null : (int) $array['size'],
             $array['error'] ?? null,
             $array['full_path'] ?? null
         );

system/Helpers/number_helper.php

@@ -144,7 +144,7 @@ function format_number(float $num, int $precision = 1, ?string $locale = null, a
 
         // Try to format it per the locale
         if ($type === NumberFormatter::CURRENCY) {
-            $formatter->setAttribute(NumberFormatter::FRACTION_DIGITS, $options['fraction']);
+            $formatter->setAttribute(NumberFormatter::FRACTION_DIGITS, (float) $options['fraction']);
             $output = $formatter->formatCurrency($num, $options['currency']);
         } else {
             // In order to specify a precision, we'll have to modify

system/I18n/TimeTrait.php

@@ -545,7 +545,7 @@ public function setYear($value)
     public function setMonth($value)
     {
         if (is_numeric($value) && ($value < 1 || $value > 12)) {
-            throw I18nException::forInvalidMonth($value);
+            throw I18nException::forInvalidMonth((string) $value);
         }
 
         if (is_string($value) && ! is_numeric($value)) {
@@ -567,13 +567,13 @@ public function setMonth($value)
     public function setDay($value)
     {
         if ($value < 1 || $value > 31) {
-            throw I18nException::forInvalidDay($value);
+            throw I18nException::forInvalidDay((string) $value);
         }
 
         $date    = $this->getYear() . '-' . $this->getMonth();
         $lastDay = date('t', strtotime($date));
         if ($value > $lastDay) {
-            throw I18nException::forInvalidOverDay($lastDay, $value);
+            throw I18nException::forInvalidOverDay($lastDay, (string) $value);
         }
 
         return $this->setValue('day', $value);
@@ -591,7 +591,7 @@ public function setDay($value)
     public function setHour($value)
     {
         if ($value < 0 || $value > 23) {
-            throw I18nException::forInvalidHour($value);
+            throw I18nException::forInvalidHour((string) $value);
         }
 
         return $this->setValue('hour', $value);
@@ -609,7 +609,7 @@ public function setHour($value)
     public function setMinute($value)
     {
         if ($value < 0 || $value > 59) {
-            throw I18nException::forInvalidMinutes($value);
+            throw I18nException::forInvalidMinutes((string) $value);
         }
 
         return $this->setValue('minute', $value);
@@ -627,7 +627,7 @@ public function setMinute($value)
     public function setSecond($value)
     {
         if ($value < 0 || $value > 59) {
-            throw I18nException::forInvalidSeconds($value);
+            throw I18nException::forInvalidSeconds((string) $value);
         }
 
         return $this->setValue('second', $value);

system/Router/RouteCollection.php

@@ -1369,14 +1369,14 @@ protected function buildReverseRoute(string $from, array $params): string
             // or maybe $placeholder is not a placeholder, but a regex.
             $pattern = $this->placeholders[$placeholderName] ?? $placeholder;
 
-            if (! preg_match('#^' . $pattern . '$#u', $params[$index])) {
+            if (! preg_match('#^' . $pattern . '$#u', (string) $params[$index])) {
                 throw RouterException::forInvalidParameterType();
             }
 
             // Ensure that the param we're inserting matches
             // the expected param type.
             $pos  = strpos($from, $placeholder);
-            $from = substr_replace($from, $params[$index], $pos, strlen($placeholder));
+            $from = substr_replace($from, (string) $params[$index], $pos, strlen($placeholder));
         }
 
         $from = $this->replaceLocale($from, $locale);

system/View/Filters.php

@@ -40,6 +40,10 @@ public static function date($value, string $format): string
             $value = strtotime($value);
         }
 
+        if ($value !== null) {
+            $value = (int) $value;
+        }
+
         return date($format, $value);
     }
 
@@ -160,7 +164,7 @@ public static function local_number($value, string $type = 'decimal', int $preci
             'duration'   => NumberFormatter::DURATION,
         ];
 
-        return format_number($value, $precision, $locale, ['type' => $types[$type]]);
+        return format_number((float) $value, $precision, $locale, ['type' => $types[$type]]);
     }
 
     /**
@@ -181,7 +185,7 @@ public static function local_currency($value, string $currency, ?string $locale
             'fraction' => $fraction,
         ];
 
-        return format_number($value, 2, $locale, $options);
+        return format_number((float) $value, 2, $locale, $options);
     }
 
     /**