Merge pull request #1764 from codeigniter4/routeplaceholders

Fix routing when no default route has been specified. Fixes #1758

Author: lonnieezell

system/Router/Router.php

@@ -561,6 +561,8 @@ public function autoRoute(string $uri)
 	 */
 	protected function validateRequest(array $segments)
 	{
+		$segments = array_filter($segments);
+
 		$c                  = count($segments);
 		$directory_override = isset($this->directory);
 
@@ -571,8 +573,7 @@ protected function validateRequest(array $segments)
 			$test = $this->directory . ucfirst($this->translateURIDashes === true ? str_replace('-', '_', $segments[0]) : $segments[0]
 			);
 
-			if (! is_file(APPPATH . 'Controllers/' . $test . '.php') && $directory_override === false && is_dir(APPPATH . 'Controllers/' . $this->directory . ucfirst($segments[0]))
-			)
+			if (! is_file(APPPATH . 'Controllers/' . $test . '.php') && $directory_override === false && is_dir(APPPATH . 'Controllers/' . $this->directory . ucfirst($segments[0])))
 			{
 				$this->setDirectory(array_shift($segments), true);
 				continue;

user_guide_src/source/tutorial/static_pages.rst

@@ -31,15 +31,15 @@ code.
 
 ::
 
-        <?php namespace App\Controllers;
-        use CodeIgniter\Controller;
+    <?php namespace App\Controllers;
+    use CodeIgniter\Controller;
 
 	class Pages extends Controller {
 
-                public function index()
-                {
-                        return view('welcome_message');
-                }
+        public function index()
+        {
+            return view('welcome_message');
+        }
 
 		public function showme($page = 'home')
 		{
@@ -204,12 +204,6 @@ The only uncommented line there to start with should be:::
 This directive says that any incoming request without any content
 specified should be handled by the ``index`` method inside the ``Home`` controller.
 
-Set the default controller to run your new method:
-
-::
-
-    $routes->setDefaultController('Pages/showme');
-
 Add the following line, **after** the route directive for '/'.
 
 ::
@@ -236,4 +230,4 @@ method in the pages controller? Awesome!
 You should see something like the following:
 
 .. image:: ../images/tutorial1.png
-    :align: center
+    :align: center