Initial commit fixing wrong return value in Database/BaseConnection::query. When underlying resultID if false, this should return false. Added BadQueryTest to tests.

Author: sneakyimp

system/Database/BaseConnection.php

@@ -675,7 +675,7 @@ public function query(string $sql, $binds = null, bool $setEscapeFlags = true, s
 				Events::trigger('DBQuery', $query);
 			}
 
-			return new $resultClass($this->connID, $this->resultID);
+			return false;
 		}
 
 		$query->setDuration($startTime);

tests/system/Database/Live/BadQueryTest.php

@@ -0,0 +1,22 @@
+<?php namespace CodeIgniter\Database\Live;
+
+use CodeIgniter\Test\CIDatabaseTestCase;
+
+/**
+ * @group DatabaseLive
+ */
+class BadQueryTest extends CIDatabaseTestCase
+{
+	protected $refresh = true;
+
+	protected $seed = 'Tests\Support\Database\Seeds\CITestSeeder';
+
+	public function testBadQuery()
+	{
+		// this throws an exception in this testing environment, but in production it'll return FALSE
+		// perhaps check $this->db->DBDebug for different test?
+		$query = $this->db->query('SELECT * FROM table_does_not_exist');
+		$this->assertEquals(false, $query);
+	}
+
+}