Merge pull request #6492 from kenjis/fix-validation-greater_than_equal_to

fix: Strict Validation Rules greater_than/less_than

Author: kenjis

system/Validation/StrictRules/Rules.php

@@ -71,20 +71,36 @@ public function exact_length($str, string $val): bool
     /**
      * Greater than
      *
-     * @param mixed $str
+     * @param mixed $str expects int|string
      */
     public function greater_than($str, string $min): bool
     {
+        if (is_int($str)) {
+            $str = (string) $str;
+        }
+
+        if (! is_string($str)) {
+            return false;
+        }
+
         return $this->nonStrictRules->greater_than($str, $min);
     }
 
     /**
      * Equal to or Greater than
      *
-     * @param mixed $str
+     * @param mixed $str expects int|string
      */
     public function greater_than_equal_to($str, string $min): bool
     {
+        if (is_int($str)) {
+            $str = (string) $str;
+        }
+
+        if (! is_string($str)) {
+            return false;
+        }
+
         return $this->nonStrictRules->greater_than_equal_to($str, $min);
     }
 
@@ -141,20 +157,36 @@ public function is_unique($str, string $field, array $data): bool
     /**
      * Less than
      *
-     * @param mixed $str
+     * @param mixed $str expects int|string
      */
     public function less_than($str, string $max): bool
     {
+        if (is_int($str)) {
+            $str = (string) $str;
+        }
+
+        if (! is_string($str)) {
+            return false;
+        }
+
         return $this->nonStrictRules->less_than($str, $max);
     }
 
     /**
      * Equal to or Less than
      *
-     * @param mixed $str
+     * @param mixed $str expects int|string
      */
     public function less_than_equal_to($str, string $max): bool
     {
+        if (is_int($str)) {
+            $str = (string) $str;
+        }
+
+        if (! is_string($str)) {
+            return false;
+        }
+
         return $this->nonStrictRules->less_than_equal_to($str, $max);
     }
 

tests/system/Validation/RulesTest.php

@@ -19,11 +19,13 @@
 
 /**
  * @internal
+ *
+ * @no-final
  */
-final class RulesTest extends CIUnitTestCase
+class RulesTest extends CIUnitTestCase
 {
-    private Validation $validation;
-    private array $config = [
+    protected Validation $validation;
+    protected array $config = [
         'ruleSets' => [
             Rules::class,
             FormatRules::class,