Merge pull request #8702 from kenjis/fix-pager-only-empty

fix: `Pager::only([])` does not work

Author: kenjis

phpstan-baseline.php

@@ -7931,21 +7931,11 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/Pager/Pager.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Only booleans are allowed in an if condition, array given\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Pager/Pager.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Property CodeIgniter\\\\Pager\\\\Pager\\:\\:\\$groups type has no value type specified in iterable type array\\.$#',
 	'count' => 1,
 	'path' => __DIR__ . '/system/Pager/Pager.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Property CodeIgniter\\\\Pager\\\\Pager\\:\\:\\$only type has no value type specified in iterable type array\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Pager/Pager.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Property CodeIgniter\\\\Pager\\\\Pager\\:\\:\\$segment type has no value type specified in iterable type array\\.$#',
 	'count' => 1,

system/Pager/Pager.php

@@ -60,9 +60,9 @@ class Pager implements PagerInterface
     /**
      * List of only permitted queries
      *
-     * @var array
+     * @var list<string>|null
      */
-    protected $only = [];
+    protected $only;
 
     /**
      * Constructor.
@@ -276,7 +276,7 @@ public function getPageURI(?int $page = null, string $group = 'default', bool $r
             $uri->addQuery($this->groups[$group]['pageSelector'], $page);
         }
 
-        if ($this->only) {
+        if ($this->only !== null) {
             $query = array_intersect_key($_GET, array_flip($this->only));
 
             if (! $segment) {

tests/system/Pager/PagerTest.php

@@ -165,6 +165,10 @@ public function testStoreWithQueries(): void
             'http://example.com/?foo=bar&page=5',
             $this->pager->only(['foo'])->getPageURI(5)
         );
+        $this->assertSame(
+            'http://example.com/?page=5',
+            $this->pager->only([])->getPageURI(5)
+        );
     }
 
     public function testStoreWithSegments(): void
@@ -181,6 +185,10 @@ public function testStoreWithSegments(): void
             'http://example.com/5?foo=bar',
             $this->pager->only(['foo'])->getPageURI(5)
         );
+        $this->assertSame(
+            'http://example.com/5',
+            $this->pager->only([])->getPageURI(5)
+        );
     }
 
     public function testGetPageURIWithURIReturnObject(): void