refactor: add $columnNamesToDrop

Author: kenjis

system/Database/SQLSRV/Forge.php

@@ -136,15 +136,17 @@ protected function _alterTable(string $alterType, string $table, $processedField
     {
         // Handle DROP here
         if ($alterType === 'DROP') {
+            $columnNamesToDrop = $processedFields;
+
             // check if fields are part of any indexes
             $indexData = $this->db->getIndexData($table);
 
             foreach ($indexData as $index) {
-                if (is_string($processedFields)) {
-                    $processedFields = explode(',', $processedFields);
+                if (is_string($columnNamesToDrop)) {
+                    $columnNamesToDrop = explode(',', $columnNamesToDrop);
                 }
 
-                $fld = array_intersect($processedFields, $index->fields);
+                $fld = array_intersect($columnNamesToDrop, $index->fields);
 
                 // Drop index if field is part of an index
                 if ($fld !== []) {
@@ -155,7 +157,7 @@ protected function _alterTable(string $alterType, string $table, $processedField
             $fullTable = $this->db->escapeIdentifiers($this->db->schema) . '.' . $this->db->escapeIdentifiers($table);
 
             // Drop default constraints
-            $fields = implode(',', $this->db->escape((array) $processedFields));
+            $fields = implode(',', $this->db->escape((array) $columnNamesToDrop));
 
             $sql = <<<SQL
                 SELECT name
@@ -172,7 +174,7 @@ protected function _alterTable(string $alterType, string $table, $processedField
 
             $sql = 'ALTER TABLE ' . $fullTable . ' DROP ';
 
-            $fields = array_map(static fn ($item) => 'COLUMN [' . trim($item) . ']', (array) $processedFields);
+            $fields = array_map(static fn ($item) => 'COLUMN [' . trim($item) . ']', (array) $columnNamesToDrop);
 
             return $sql . implode(',', $fields);
         }

system/Database/SQLite3/Forge.php

@@ -120,10 +120,12 @@ protected function _alterTable(string $alterType, string $table, $processedField
     {
         switch ($alterType) {
             case 'DROP':
+                $columnNamesToDrop = $processedFields;
+
                 $sqlTable = new Table($this->db, $this);
 
                 $sqlTable->fromTable($table)
-                    ->dropColumn($processedFields)
+                    ->dropColumn($columnNamesToDrop)
                     ->run();
 
                 return ''; // Why empty string?