Skip to content

Commit 0ea37ad

Browse files
committed
test: restore testUnserializeTimeObject()
1 parent 04b70af commit 0ea37ad

File tree

2 files changed

+20
-22
lines changed

2 files changed

+20
-22
lines changed

tests/system/I18n/TimeLegacyTest.php

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1123,17 +1123,16 @@ public function testGetter(): void
11231123
$this->assertNull($time->weekOfWeek);
11241124
}
11251125

1126-
// @TODO Uncomment when PHP 8.2.4 Segmentation fault fixed.
1127-
// public function testUnserializeTimeObject()
1128-
// {
1129-
// $time1 = new TimeLegacy('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
1130-
// $timeCache = serialize($time1);
1131-
// $time2 = unserialize($timeCache);
1132-
//
1133-
// $this->assertInstanceOf(TimeLegacy::class, $time2);
1134-
// $this->assertTrue($time2->equals($time1));
1135-
// $this->assertNotSame($time1, $time2);
1136-
// }
1126+
public function testUnserializeTimeObject()
1127+
{
1128+
$time1 = new TimeLegacy('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
1129+
$timeCache = serialize($time1);
1130+
$time2 = unserialize($timeCache);
1131+
1132+
$this->assertInstanceOf(TimeLegacy::class, $time2);
1133+
$this->assertTrue($time2->equals($time1));
1134+
$this->assertNotSame($time1, $time2);
1135+
}
11371136

11381137
public function testSetTestNowWithFaLocale(): void
11391138
{

tests/system/I18n/TimeTest.php

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1126,17 +1126,16 @@ public function testGetter(): void
11261126
$this->assertNull($time->weekOfWeek);
11271127
}
11281128

1129-
// @TODO Uncomment when PHP 8.2.4 Segmentation fault fixed.
1130-
// public function testUnserializeTimeObject()
1131-
// {
1132-
// $time1 = new Time('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
1133-
// $timeCache = serialize($time1);
1134-
// $time2 = unserialize($timeCache);
1135-
//
1136-
// $this->assertInstanceOf(Time::class, $time2);
1137-
// $this->assertTrue($time2->equals($time1));
1138-
// $this->assertNotSame($time1, $time2);
1139-
// }
1129+
public function testUnserializeTimeObject()
1130+
{
1131+
$time1 = new Time('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
1132+
$timeCache = serialize($time1);
1133+
$time2 = unserialize($timeCache);
1134+
1135+
$this->assertInstanceOf(Time::class, $time2);
1136+
$this->assertTrue($time2->equals($time1));
1137+
$this->assertNotSame($time1, $time2);
1138+
}
11401139

11411140
public function testSetTestNowWithTimeZone(): void
11421141
{

0 commit comments

Comments
 (0)