fix: SQLSRV Forge::modifyColumn() changes NULL incorrectly

Author: kenjis

system/Database/SQLSRV/Forge.php

@@ -203,10 +203,14 @@ protected function _alterTable(string $alterType, string $table, $field)
                     . " DEFAULT {$data['default']} FOR " . $this->db->escapeIdentifiers($data['name']);
             }
 
+            $nullable = true; // Nullable by default.
             if (isset($data['null'])) {
-                $sqls[] = $sql . ' ALTER COLUMN ' . $this->db->escapeIdentifiers($data['name'])
-                    . ($data['null'] === true ? ' DROP' : '') . " {$data['type']}{$data['length']} NOT NULL";
+                if ($data['null'] === false || $data['null'] === ' NOT ' . $this->null) {
+                    $nullable = false;
+                }
             }
+            $sqls[] = $sql . ' ALTER COLUMN ' . $this->db->escapeIdentifiers($data['name'])
+                . " {$data['type']}{$data['length']} " . ($nullable === true ? '' : 'NOT') . ' NULL';
 
             if (! empty($data['comment'])) {
                 $sqls[] = 'EXEC sys.sp_addextendedproperty '

tests/system/Database/Live/ForgeTest.php

@@ -1313,9 +1313,9 @@ public function testModifyColumnNullTrue()
 
     public function testModifyColumnNullFalse()
     {
-        if ($this->db->DBDriver === 'SQLSRV') {
-            $this->markTestSkipped('SQLSRV does not support getFieldData() nullable.');
-        }
+        //        if ($this->db->DBDriver === 'SQLSRV') {
+        //            $this->markTestSkipped('SQLSRV does not support getFieldData() nullable.');
+        //        }
 
         $this->forge->dropTable('forge_test_modify', true);
 
@@ -1341,7 +1341,7 @@ public function testModifyColumnNullFalse()
         $col3 = $this->getMetaData('col3', 'forge_test_modify');
         $this->assertFalse($col3->nullable);
 
-        $this->forge->dropTable('forge_test_modify', true);
+//        $this->forge->dropTable('forge_test_modify', true);
     }
 
     private function getMetaData(string $column, string $table): stdClass