Skip to content

Commit a9ab27c

Browse files
committed
replace most handwritten components.xml with annotations
fixes #275
1 parent e98cde5 commit a9ab27c

File tree

46 files changed

+114
-270
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+114
-270
lines changed

modello-core/pom.xml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,17 @@
4848
</archive>
4949
</configuration>
5050
</plugin>
51+
<plugin>
52+
<groupId>org.codehaus.plexus</groupId>
53+
<artifactId>plexus-component-metadata</artifactId>
54+
<executions>
55+
<execution>
56+
<goals>
57+
<goal>merge-metadata</goal>
58+
</goals>
59+
</execution>
60+
</executions>
61+
</plugin>
5162
</plugins>
5263
</build>
5364
</project>

modello-core/src/main/java/org/codehaus/modello/core/DefaultModelloCore.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
import org.codehaus.modello.model.ModelInterface;
4141
import org.codehaus.modello.model.ModelValidationException;
4242
import org.codehaus.modello.plugin.ModelloGenerator;
43+
import org.codehaus.plexus.component.annotations.Component;
44+
import org.codehaus.plexus.component.annotations.Requirement;
4345
import org.codehaus.plexus.util.ReaderFactory;
4446

4547
import java.io.File;
@@ -55,17 +57,14 @@
5557
* @author <a href="mailto:[email protected]">Trygve Laugst&oslash;l</a>
5658
* @author <a href="mailto:[email protected]">Emmanuel Venisse</a>
5759
*/
60+
@Component( role = ModelloCore.class )
5861
public class DefaultModelloCore
5962
extends AbstractModelloCore
6063
{
61-
/**
62-
* @requirement
63-
*/
64+
@Requirement
6465
private MetadataPluginManager metadataPluginManager;
6566

66-
/**
67-
* @requirement
68-
*/
67+
@Requirement
6968
private GeneratorPluginManager generatorPluginManager;
7069

7170
public MetadataPluginManager getMetadataPluginManager()

modello-core/src/main/java/org/codehaus/modello/plugin/AbstractPluginManager.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
*/
2424

2525
import org.codehaus.modello.ModelloRuntimeException;
26+
2627
import org.codehaus.plexus.logging.AbstractLogEnabled;
2728
import org.codehaus.plexus.personality.plexus.lifecycle.phase.Initializable;
2829

modello-core/src/main/java/org/codehaus/modello/plugin/model/ModelMetadataPlugin.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,14 @@
3434
import org.codehaus.modello.model.ModelClass;
3535
import org.codehaus.modello.model.ModelField;
3636
import org.codehaus.modello.model.ModelInterface;
37+
import org.codehaus.plexus.component.annotations.Component;
3738

3839
import java.util.Map;
3940

4041
/**
4142
* @author <a href="mailto:[email protected]">Emmanuel Venisse</a>
4243
*/
44+
@Component( role = MetadataPlugin.class, hint = "model" )
4345
public class ModelMetadataPlugin
4446
extends AbstractMetadataPlugin
4547
implements MetadataPlugin
Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,5 @@
11
<component-set>
22
<components>
3-
<component>
4-
<role>org.codehaus.modello.core.ModelloCore</role>
5-
<implementation>org.codehaus.modello.core.DefaultModelloCore</implementation>
6-
<instantiation-strategy>per-lookup</instantiation-strategy>
7-
<requirements>
8-
<requirement>
9-
<role>org.codehaus.modello.core.MetadataPluginManager</role>
10-
</requirement>
11-
<requirement>
12-
<role>org.codehaus.modello.core.GeneratorPluginManager</role>
13-
</requirement>
14-
</requirements>
15-
</component>
163
<component>
174
<role>org.codehaus.modello.core.MetadataPluginManager</role>
185
<implementation>org.codehaus.modello.core.DefaultMetadataPluginManager</implementation>
@@ -35,11 +22,5 @@
3522
</requirement>
3623
</requirements>
3724
</component>
38-
39-
<component>
40-
<role>org.codehaus.modello.metadata.MetadataPlugin</role>
41-
<role-hint>model</role-hint>
42-
<implementation>org.codehaus.modello.plugin.model.ModelMetadataPlugin</implementation>
43-
</component>
4425
</components>
4526
</component-set>

modello-plugins/modello-plugin-converters/src/main/java/org/codehaus/modello/plugin/converters/ConverterGenerator.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import org.codehaus.modello.model.ModelField;
3333
import org.codehaus.modello.model.Version;
3434
import org.codehaus.modello.model.VersionDefinition;
35+
import org.codehaus.modello.plugin.ModelloGenerator;
3536
import org.codehaus.modello.plugin.java.AbstractJavaModelloGenerator;
3637
import org.codehaus.modello.plugin.java.javasource.JClass;
3738
import org.codehaus.modello.plugin.java.javasource.JInterface;
@@ -43,6 +44,7 @@
4344
import org.codehaus.modello.plugin.java.javasource.JType;
4445
import org.codehaus.modello.plugin.java.metadata.JavaClassMetadata;
4546
import org.codehaus.modello.plugin.java.metadata.JavaFieldMetadata;
47+
import org.codehaus.plexus.component.annotations.Component;
4648
import org.codehaus.plexus.util.IOUtil;
4749

4850
import java.io.IOException;
@@ -54,6 +56,7 @@
5456
/**
5557
* Generate a basic conversion class between two versions of a model.
5658
*/
59+
@Component( role = ModelloGenerator.class, hint = "converters" )
5760
public class ConverterGenerator
5861
extends AbstractJavaModelloGenerator
5962
{

modello-plugins/modello-plugin-converters/src/main/resources/META-INF/plexus/components.xml

Lines changed: 0 additions & 10 deletions
This file was deleted.

modello-plugins/modello-plugin-dom4j/src/main/java/org/codehaus/modello/plugin/dom4j/Dom4jReaderGenerator.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.codehaus.modello.model.ModelClass;
2929
import org.codehaus.modello.model.ModelDefault;
3030
import org.codehaus.modello.model.ModelField;
31+
import org.codehaus.modello.plugin.ModelloGenerator;
3132
import org.codehaus.modello.plugin.java.javasource.JClass;
3233
import org.codehaus.modello.plugin.java.javasource.JMethod;
3334
import org.codehaus.modello.plugin.java.javasource.JParameter;
@@ -37,6 +38,7 @@
3738
import org.codehaus.modello.plugins.xml.AbstractXmlJavaGenerator;
3839
import org.codehaus.modello.plugins.xml.metadata.XmlAssociationMetadata;
3940
import org.codehaus.modello.plugins.xml.metadata.XmlFieldMetadata;
41+
import org.codehaus.plexus.component.annotations.Component;
4042
import org.codehaus.plexus.util.StringUtils;
4143

4244
import java.io.IOException;
@@ -49,6 +51,7 @@
4951
*
5052
* @author <a href="mailto:[email protected]">Brett Porter</a>
5153
*/
54+
@Component( role = ModelloGenerator.class, hint = "dom4j-reader" )
5255
public class Dom4jReaderGenerator
5356
extends AbstractXmlJavaGenerator
5457
{

modello-plugins/modello-plugin-dom4j/src/main/java/org/codehaus/modello/plugin/dom4j/Dom4jWriterGenerator.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.codehaus.modello.model.ModelClass;
2929
import org.codehaus.modello.model.ModelDefault;
3030
import org.codehaus.modello.model.ModelField;
31+
import org.codehaus.modello.plugin.ModelloGenerator;
3132
import org.codehaus.modello.plugin.java.javasource.JClass;
3233
import org.codehaus.modello.plugin.java.javasource.JMethod;
3334
import org.codehaus.modello.plugin.java.javasource.JParameter;
@@ -39,6 +40,7 @@
3940
import org.codehaus.modello.plugins.xml.metadata.XmlAssociationMetadata;
4041
import org.codehaus.modello.plugins.xml.metadata.XmlFieldMetadata;
4142
import org.codehaus.modello.plugins.xml.metadata.XmlModelMetadata;
43+
import org.codehaus.plexus.component.annotations.Component;
4244

4345
import java.io.IOException;
4446
import java.util.List;
@@ -52,6 +54,7 @@
5254
*
5355
* @author <a href="mailto:[email protected]">Brett Porter</a>
5456
*/
57+
@Component( role = ModelloGenerator.class, hint = "dom4j-writer" )
5558
public class Dom4jWriterGenerator
5659
extends AbstractXmlJavaGenerator
5760
{

modello-plugins/modello-plugin-dom4j/src/main/resources/META-INF/plexus/components.xml

Lines changed: 0 additions & 16 deletions
This file was deleted.

0 commit comments

Comments
 (0)