Fix escaping for context name in API call

Author: sandrogattuso

client/context.go

@@ -32,7 +32,7 @@ func (context *Context) GetID() string {
 }
 
 func (client *Client) GetContext(name string) (*Context, error) {
-	fullPath := fmt.Sprintf("/contexts/%s?decrypt=true", url.QueryEscape(name))
+	fullPath := fmt.Sprintf("/contexts/%s?decrypt=true", url.PathEscape(name))
 	opts := RequestOptions{
 		Path:   fullPath,
 		Method: "GET",
@@ -91,7 +91,7 @@ func (client *Client) UpdateContext(context *Context) (*Context, error) {
 		return nil, err
 	}
 
-	fullPath := fmt.Sprintf("/contexts/%s", url.QueryEscape(context.Metadata.Name))
+	fullPath := fmt.Sprintf("/contexts/%s", url.PathEscape(context.Metadata.Name))
 	opts := RequestOptions{
 		Path:   fullPath,
 		Method: "PUT",
@@ -116,7 +116,7 @@ func (client *Client) UpdateContext(context *Context) (*Context, error) {
 
 func (client *Client) DeleteContext(name string) error {
 
-	fullPath := fmt.Sprintf("/contexts/%s", url.QueryEscape(name))
+	fullPath := fmt.Sprintf("/contexts/%s", url.PathEscape(name))
 	opts := RequestOptions{
 		Path:   fullPath,
 		Method: "DELETE",

codefresh/resource_context_test.go

@@ -13,6 +13,33 @@ import (
 
 var contextNamePrefix = "TerraformAccTest_"
 
+func TestAccCodefreshContextConfigWithCharactersToBeEscaped(t *testing.T) {
+	name := contextNamePrefix + "cf ctx/test +?#@ special" + acctest.RandString(10)
+	resourceName := "codefresh_context.test"
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckCodefreshContextDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccCodefreshContextConfig(name, "config1", "value1", "config2", "value2"),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckCodefreshContextExists(resourceName),
+					resource.TestCheckResourceAttr(resourceName, "name", name),
+					resource.TestCheckResourceAttr(resourceName, "spec.0.config.0.data.config1", "value1"),
+					resource.TestCheckResourceAttr(resourceName, "spec.0.config.0.data.config2", "value2"),
+				),
+			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
 func TestAccCodefreshContextConfig(t *testing.T) {
 	name := contextNamePrefix + acctest.RandString(10)
 	resourceName := "codefresh_context.test"