From b0957af564c52b269dc95adbc87d32c2f7c7c4de Mon Sep 17 00:00:00 2001 From: PeterNgTr Date: Wed, 13 Jul 2022 16:42:06 +0200 Subject: [PATCH 1/3] fix: TS complains secret args --- lib/secret.js | 3 ++- test/rest/REST_test.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/secret.js b/lib/secret.js index 9613816a8..19438dd66 100644 --- a/lib/secret.js +++ b/lib/secret.js @@ -18,9 +18,10 @@ class Secret { /** * @param {*} secret + * @param {*} [fieldToHide] * @returns {Secret} */ - static secret(secret) { + static secret(secret, fieldToHide) { if (typeof secret === 'object') { const fields = Array.from(arguments); fields.shift(); diff --git a/test/rest/REST_test.js b/test/rest/REST_test.js index c3724a382..149bafb1d 100644 --- a/test/rest/REST_test.js +++ b/test/rest/REST_test.js @@ -1,7 +1,7 @@ const path = require('path'); const fs = require('fs'); const FormData = require('form-data'); -const secret = require('../../lib/secret').secret; +const { secret } = require('../../lib/secret'); const TestHelper = require('../support/TestHelper'); const REST = require('../../lib/helper/REST'); From 24a34622b79430c0a2c42f8925fe642ecce6c0a9 Mon Sep 17 00:00:00 2001 From: PeterNgTr Date: Thu, 14 Jul 2022 05:53:20 +0200 Subject: [PATCH 2/3] fix: TS complains secret args --- lib/secret.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/secret.js b/lib/secret.js index 19438dd66..2364d7249 100644 --- a/lib/secret.js +++ b/lib/secret.js @@ -21,7 +21,7 @@ class Secret { * @param {*} [fieldToHide] * @returns {Secret} */ - static secret(secret, fieldToHide) { + static secret(secret, fieldToHide = null) { if (typeof secret === 'object') { const fields = Array.from(arguments); fields.shift(); From 2d0140a911f478e0284ecfd578b56386e0dd3e32 Mon Sep 17 00:00:00 2001 From: PeterNgTr Date: Thu, 14 Jul 2022 10:54:43 +0200 Subject: [PATCH 3/3] fix: TS complains secret args --- lib/secret.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/secret.js b/lib/secret.js index 2364d7249..cde2c5d8a 100644 --- a/lib/secret.js +++ b/lib/secret.js @@ -17,11 +17,10 @@ class Secret { } /** - * @param {*} secret - * @param {*} [fieldToHide] + * @param {...*} secret * @returns {Secret} */ - static secret(secret, fieldToHide = null) { + static secret(secret) { if (typeof secret === 'object') { const fields = Array.from(arguments); fields.shift();