improve: jsonresponse validation #3316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arhell
approved these changes
May 21, 2022
DavertMik
requested changes
Jul 6, 2022
Contributor
DavertMik
left a comment
DavertMik
left a comment
There was a problem hiding this comment.
At first I thought maybe this PR is not so useful enough but then I looked into tests and figured out that these use cases are quite important to cover.
Please update documentation for updated methods to mention this use case with arrays.
Also remove change to seeResponseEquals method
DavertMik
requested changes
Jul 11, 2022
Contributor
DavertMik
left a comment
DavertMik
left a comment
There was a problem hiding this comment.
Also, it would be nice if we mention explicitly in the documentation what we do with arrays. Not only as a code examples but with explanation.
DavertMik
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Type of change
Checklist:
npm run docs)npm run lint)npm test)