Skip to content

Commit 5f54929

Browse files
authored
Playwright: Fixed parameters of startActivity() (#3408)
1 parent f288fad commit 5f54929

File tree

3 files changed

+15
-8
lines changed

3 files changed

+15
-8
lines changed

docs/helpers/Appium.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -433,12 +433,14 @@ Start an arbitrary Android activity during a session.
433433
I.startActivity('io.selendroid.testapp', '.RegisterUserActivity');
434434
```
435435

436+
Appium: support only Android
437+
436438
#### Parameters
437439

438-
- `appPackage`
439-
- `appActivity`
440+
- `appPackage` **[string][4]**
441+
- `appActivity` **[string][4]**
440442

441-
Returns **[Promise][5]<void>** Appium: support only Android
443+
Returns **[Promise][5]<void>**
442444

443445
### setNetworkConnection
444446

lib/helper/Appium.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -788,9 +788,11 @@ class Appium extends Webdriver {
788788
* I.startActivity('io.selendroid.testapp', '.RegisterUserActivity');
789789
* ```
790790
*
791-
* @return {Promise<void>}
792-
*
793791
* Appium: support only Android
792+
*
793+
* @param {string} appPackage
794+
* @param {string} appActivity
795+
* @return {Promise<void>}
794796
*/
795797
async startActivity(appPackage, appActivity) {
796798
onlyForApps.call(this, 'Android');

typings/tests/helpers/Appium.types.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ const appium = new CodeceptJS.Appium();
22

33
const str_ap = "text";
44
const num_ap = 1;
5+
const appPackage = "com.example.android.apis";
56

67
appium.touchPerform(); // $ExpectError
78
appium.touchPerform("press"); // $ExpectError
@@ -16,8 +17,8 @@ appium.hideDeviceKeyboard("pressKey", "Done", "Done"); // $ExpectError
1617

1718
appium.removeApp(); // $ExpectError
1819
appium.removeApp("appName"); // $ExpectType void
19-
appium.removeApp("appName", "com.example.android.apis"); // $ExpectType void
20-
appium.removeApp("appName", "com.example.android.apis", "remove"); // $ExpectError
20+
appium.removeApp("appName", appPackage); // $ExpectType void
21+
appium.removeApp("appName", appPackage, "remove"); // $ExpectError
2122

2223
appium.runOnIOS(str_ap, () => {}); // $ExpectType void
2324
appium.runOnAndroid(str_ap, () => {}); // $ExpectType void
@@ -40,7 +41,9 @@ appium._switchToContext(str_ap); // $ExpectType void
4041
appium.switchToWeb(); // $ExpectType Promise<void>
4142
appium.switchToNative(); // $ExpectType Promise<void>
4243
appium.switchToNative(str_ap); // $ExpectType Promise<void>
43-
appium.startActivity(); // $ExpectType Promise<void>
44+
appium.startActivity(); // $ExpectError
45+
appium.startActivity(appPackage); // $ExpectError
46+
appium.startActivity(appPackage, '.RegisterUserActivity'); // $ExpectType Promise<void>
4447
appium.setNetworkConnection(); // $ExpectType Promise<{}>
4548
appium.setSettings(str_ap); // $ExpectType void
4649
appium.hideDeviceKeyboard(); // $ExpectType void

0 commit comments

Comments
 (0)