Fix custom locator registration timing and format issues

Co-authored-by: kobenguyent <[email protected]>

Author: Copilot

lib/helper/Playwright.js

@@ -895,52 +895,48 @@ class Playwright extends Helper {
 
   async _registerCustomLocatorStrategies() {
     if (this._isCustomLocatorStrategyDefined()) {
+      console.log('[DEBUG] Registering custom locator strategies:', Object.keys(this.customLocatorStrategies))
       for (const [strategyName, strategyFunction] of Object.entries(this.customLocatorStrategies)) {
-        // Skip if already registered
-        if (registeredCustomLocatorStrategies.has(strategyName)) {
-          continue
-        }
-
         try {
+          console.log(`[DEBUG] Registering custom locator strategy: ${strategyName}`)
           this.debugSection('Playwright', `registering custom locator strategy: ${strategyName}`)
 
-          // Convert the function to a string and create the selector engine content
-          const functionString = strategyFunction.toString()
-          const selectorEngine =
-            `
-            exports.query = (root, selector) => {
+          // Create a selector engine object similar to the default engines
+          const selectorEngine = {
+            query(root, selector) {
               try {
-                const strategyFunction = ${functionString};
                 const result = strategyFunction(selector, root);
                 return Array.isArray(result) ? result[0] : result;
               } catch (error) {
-                console.warn('Error in custom locator "` +
-            strategyName +
-            `":', error);
+                console.warn(`Error in custom locator "${strategyName}":`, error);
                 return null;
               }
-            };
+            },
 
-            exports.queryAll = (root, selector) => {
+            queryAll(root, selector) {
               try {
-                const strategyFunction = ${functionString};
                 const result = strategyFunction(selector, root);
                 return Array.isArray(result) ? result : result ? [result] : [];
               } catch (error) {
-                console.warn('Error in custom locator "` +
-            strategyName +
-            `":', error);
+                console.warn(`Error in custom locator "${strategyName}":`, error);
                 return [];
               }
-            };
-          `
+            }
+          }
 
-          await playwright.selectors.register(strategyName, { content: selectorEngine })
+          await playwright.selectors.register(strategyName, selectorEngine)
+          console.log(`[DEBUG] Successfully registered custom locator strategy: ${strategyName}`)
           registeredCustomLocatorStrategies.add(strategyName)
         } catch (error) {
-          console.warn(`Failed to register custom locator strategy '${strategyName}':`, error)
+          console.log(`[DEBUG] Error registering custom locator strategy '${strategyName}':`, error)
+          // Ignore "already registered" errors, warn about others
+          if (!error.message.includes('already registered')) {
+            console.warn(`Failed to register custom locator strategy '${strategyName}':`, error)
+          }
         }
       }
+    } else {
+      console.log('[DEBUG] No custom locator strategies defined')
     }
   }
 
@@ -1341,21 +1337,31 @@ class Playwright extends Helper {
   }
 
   async _ensureCustomLocatorsRegistered() {
+    console.log('[DEBUG] _ensureCustomLocatorsRegistered called')
+    console.log('[DEBUG] _customLocatorsRegistered:', this._customLocatorsRegistered)
+    console.log('[DEBUG] _isCustomLocatorStrategyDefined:', this._isCustomLocatorStrategyDefined())
+    
     // Only register once, and only if we have strategies defined
     if (this._customLocatorsRegistered || !this._isCustomLocatorStrategyDefined()) {
+      console.log('[DEBUG] Skipping custom locator registration - already registered or no strategies defined')
       return
     }
 
+    console.log('[DEBUG] Proceeding with custom locator registration')
     try {
       // If browser isn't running yet, start it to register selectors
       if (!this.isRunning && !this.options.manualStart) {
+        console.log('[DEBUG] Starting browser to register selectors')
         await this._startBrowser()
       } else {
+        console.log('[DEBUG] Browser running, registering selectors now')
         // If browser is running but custom locators not registered, register them now
         await this._registerCustomLocatorStrategies()
       }
       this._customLocatorsRegistered = true
+      console.log('[DEBUG] Custom locator registration completed')
     } catch (error) {
+      console.log('[DEBUG] Failed to register custom locators:', error)
       console.warn('Failed to register custom locators:', error.message)
       // Continue execution - the error will surface when the locator is actually used
     }