Fix calibration decoding, and lagged backfill processing (LoopKit#35)

Author: ps2

G7SensorKit/G7CGMManager/G7BackfillMessage.swift

@@ -32,18 +32,19 @@ public struct G7BackfillMessage: Equatable {
             return nil
         }
 
-        timestamp = data[0..<4].toInt()
+        
+        timestamp = data[0..<3].toInt()
 
         let glucoseBytes = data[4..<6].to(UInt16.self)
 
         if glucoseBytes != 0xffff {
             glucose = glucoseBytes & 0xfff
-            glucoseIsDisplayOnly = (glucoseBytes & 0xf000) > 0
         } else {
             glucose = nil
-            glucoseIsDisplayOnly = false
         }
 
+        glucoseIsDisplayOnly = data[7] & 0x10 != 0
+
         algorithmState = AlgorithmState(rawValue: data[6])
 
         if data[8] == 0x7f {

G7SensorKit/G7CGMManager/G7Sensor.swift

@@ -195,6 +195,9 @@ public final class G7Sensor: G7BluetoothManagerDelegate {
     func peripheralDidDisconnect(_ manager: G7BluetoothManager, peripheralManager: G7PeripheralManager, wasRemoteDisconnect: Bool) {
         if let sensorID = sensorID, sensorID == peripheralManager.peripheral.name {
 
+            // Sometimes we do not receive the backfillFinished message before disconnect
+            flushBackfillBuffer()
+
             let suspectedEndOfSession: Bool
 
             self.log.info("Sensor disconnected: wasRemoteDisconnect:%{public}@", String(describing: wasRemoteDisconnect))
@@ -249,18 +252,23 @@ public final class G7Sensor: G7BluetoothManagerDelegate {
                 }
             }
         case .backfillFinished:
-            if backfillBuffer.count > 0 {
-                delegateQueue.async {
-                    self.delegate?.sensor(self, didReadBackfill: self.backfillBuffer)
-                    self.backfillBuffer = []
-                }
-            }
+            flushBackfillBuffer()
         default:
             self.delegate?.sensor(self, logComms: response.hexadecimalString)
             break
         }
     }
 
+    func flushBackfillBuffer() {
+        if backfillBuffer.count > 0 {
+            let backfill = backfillBuffer
+            self.backfillBuffer = []
+            delegateQueue.async {
+                self.delegate?.sensor(self, didReadBackfill: backfill)
+            }
+        }
+    }
+
     func bluetoothManager(_ manager: G7BluetoothManager, didReceiveBackfillResponse response: Data) {
 
         log.debug("Received backfill response: %{public}@", response.hexadecimalString)

G7SensorKitTests/G7GlucoseMessageTests.swift

@@ -131,6 +131,23 @@ final class G7GlucoseMessageTests: XCTestCase {
         let data = Data(hexadecimalString: "cf5802008f00060f10")!
         let message = G7BackfillMessage(data: data)!
         XCTAssertEqual(153807, message.timestamp)
+        XCTAssertEqual(143, message.glucose)
+        XCTAssertEqual(.known(.ok), message.algorithmState)
+        XCTAssertNil(message.condition)
+        XCTAssertEqual(false, message.glucoseIsDisplayOnly)
+        XCTAssertEqual(true, message.hasReliableGlucose)
+    }
+
+    func testBackfillTimestampWithHighByte() {
+        let data = Data(hexadecimalString: "f20e0d00ba00060ffb")!
+        let message = G7BackfillMessage(data: data)!
+        XCTAssertEqual(855794, message.timestamp)
+    }
+
+    func testBackfillCalibration() {
+        let data = Data(hexadecimalString: "f63d00008500061efe")!
+        let message = G7BackfillMessage(data: data)!
+        XCTAssertEqual(true, message.glucoseIsDisplayOnly)
     }
 
 }