feat: Always show interested bus captains table

Author: sman591

app/views/manage/bus_lists/show.html.haml

@@ -49,34 +49,33 @@
 
     = render "questionnaire_datatable", scope_params: { bus_list_id: @bus_list.id, acc_status: 'rsvp_confirmed' }, columns: %w(link first_name last_name email phone checked_in boarded_bus bus_captain school), order: '13 desc, 15 desc', bulk_actions: false
 
-    - if @bus_list.needs_bus_captain
-      %h4.mt-4.pb-2 Possible Bus Captains
-      %table.table
-        %thead
+    %h4.mt-4.pb-2 Interested Bus Captains
+    %table.table
+      %thead
+        %tr
+          %th
+          %th First Name
+          %th Last Name
+          %th Email
+          %th Phone Number
+          %th School
+          - if current_user.admin?
+            %th Actions
+      %tbody
+        - @bus_list.passengers.select { |q| q.bus_captain_interest }.each do |p|
           %tr
-            %th
-            %th First Name
-            %th Last Name
-            %th Email
-            %th Phone Number
-            %th School
+            %td= link_to '<i class="fa fa-search"></i>'.html_safe, manage_questionnaire_path(p)
+            %td= p.first_name
+            %td= p.last_name
+            %td= p.email
+            %td= phone_link_to p.phone
+            %td= link_to p.school.name, manage_school_path(p.school)
             - if current_user.admin?
-              %th Actions
-        %tbody
-          - @bus_list.passengers.select { |q| q.bus_captain_interest }.each do |p|
-            %tr
-              %td= link_to '<i class="fa fa-search"></i>'.html_safe, manage_questionnaire_path(p)
-              %td= p.first_name
-              %td= p.last_name
-              %td= p.email
-              %td= phone_link_to p.phone
-              %td= link_to p.school.name, manage_school_path(p.school)
-              - if current_user.admin?
-                %td
-                  - if p.is_bus_captain?
-                    = link_to "Remove Bus Captain", toggle_bus_captain_manage_bus_list_path(@bus_list, questionnaire_id: p.id, bus_captain: '0'), method: 'post', class: 'text-danger'
-                  - else
-                    = link_to "Make Bus Captain", toggle_bus_captain_manage_bus_list_path(@bus_list, questionnaire_id: p.id, bus_captain: '1'), method: 'post', data: { confirm: 'Are you sure? This will send a confirmation email to the bus captain.' }
+              %td
+                - if p.is_bus_captain?
+                  = link_to "Remove Bus Captain", toggle_bus_captain_manage_bus_list_path(@bus_list, questionnaire_id: p.id, bus_captain: '0'), method: 'post', class: 'text-danger'
+                - else
+                  = link_to "Make Bus Captain", toggle_bus_captain_manage_bus_list_path(@bus_list, questionnaire_id: p.id, bus_captain: '1'), method: 'post', data: { confirm: 'Are you sure? This will send a confirmation email to the bus captain.' }
 
 .row.mt-2.mb-4
   .col