Merge pull request #406 from codeRIT/hm-405

fix: Allows optional assets to be unset

Author: cbaudouinjr

app/controllers/manage/configs_controller.rb

@@ -17,7 +17,7 @@ def update
     value = params[:hackathon_config][key]
     value = true if value == "true"
     value = false if value == "false"
-    if @config.var.end_with?("_asset") && !value.start_with?('http://', 'https://')
+    if @config.var.start_with?("agreement_") && !value.start_with?('http://', 'https://')
       flash[:alert] = "Config \"#{key}\" must start with http:// or https://"
       render :edit
     elsif @config.value != value

test/controllers/manage/configs_controller_test.rb

@@ -152,13 +152,6 @@ class Manage::ConfigsControllerTest < ActionController::TestCase
       assert_redirected_to manage_configs_path
     end
 
-    should "not update logo_asset with an asset that is not URL based" do
-      HackathonConfig["logo_asset"] = ""
-      patch :update, params: { id: "logo_asset", hackathon_config: { logo_asset: "test" } }
-      assert_equal "", HackathonConfig["logo_asset"]
-      assert_template :edit
-    end
-
     should "update config CSS variables when custom_css is blank" do
       HackathonConfig["custom_css"] = ""
       patch :update, params: { id: "custom_css", hackathon_config: { custom_css: ":root {\n  --foo: #fff;\n}" } }