feat: Clean up datatables

Author: sman591

app/datatables/admin_datatable.rb

@@ -21,7 +21,7 @@ def data
         email: link_to(bold(record.email), manage_admin_path(record)),
         role: record.role.titleize,
         active: record.is_active ? '<span class="badge badge-secondary">Active</span>'.html_safe : '<span class="badge badge-danger">Inactive<span>'.html_safe,
-        receive_weekly_report: record.receive_weekly_report ? '<span class="badge badge-success">Yes</span>'.html_safe : '<span class="badge badge-secondary">No<span>'.html_safe,
+        receive_weekly_report: yes_no_display(record.receive_weekly_report),
         created_at: display_datetime(record.created_at),
       }
     end

app/datatables/application_datatable.rb

@@ -6,4 +6,8 @@ def initialize(params, opts = {})
     @view = opts[:view_context]
     super
   end
+
+  def yes_no_display(value)
+    value ? '<span class="badge badge-success">Yes</span>'.html_safe : '<span class="badge badge-secondary">No</span>'.html_safe
+  end
 end

app/datatables/checkin_datatable.rb

@@ -25,7 +25,7 @@ def data
         first_name: record.first_name,
         last_name: record.last_name,
         about: about(record),
-        checked_in: record.checked_in? ? "<span class=\"text-success\">Yes</span>".html_safe : "No",
+        checked_in: yes_no_display(record.checked_in?),
         actions: "<a class=\"btn btn-primary btn-sm\" href=\"#{manage_checkin_path(record)}\">View</a>".html_safe,
       }
     end

app/datatables/questionnaire_datatable.rb

@@ -57,9 +57,9 @@ def data
         phone: record.phone,
         gender: record.gender,
         date_of_birth: record.date_of_birth_formatted,
-        acc_status: "<span class=\"text-#{acc_status_class(record.acc_status)}\">#{record.acc_status.titleize}</span>".html_safe,
-        checked_in: record.checked_in? ? '<span class="badge badge-success">Yes</span>'.html_safe : "No",
-        boarded_bus: record.boarded_bus? ? '<span class="badge badge-success">Yes</span>'.html_safe : "No",
+        acc_status: "<span class=\"text-#{acc_status_class(record.acc_status)}\">#{Questionnaire::POSSIBLE_ACC_STATUS[record.acc_status]}</span>".html_safe,
+        checked_in: yes_no_display(record.checked_in?),
+        boarded_bus: yes_no_display(record.boarded_bus?),
         bus_captain: bus_captain(record),
         school: link_to(record.school.name, manage_school_path(record.school)),
         created_at: record.created_at.present? ? display_datetime(record.created_at) : "",

app/datatables/school_datatable.rb

@@ -22,7 +22,7 @@ def data
         city: record.city,
         state: record.state,
         questionnaire_count: record.questionnaire_count,
-        home_school: record.is_home ? '<span class="badge badge-success">Yes</span>'.html_safe : '<span class="badge badge-secondary">No</span>'.html_safe,
+        home_school: yes_no_display(record.is_home),
       }
     end
   end

app/views/manage/schools/show.html.haml

@@ -89,7 +89,7 @@
 
 = render "questionnaire_datatable", scope_params: { school_id: @school.id }, page_length: 25, columns: %w(link note first_name last_name email acc_status checked_in created_at)
 
-.row.mt-2.mb-4
+.row.mt-4.mb-5
   .col-lg-6
     %h4.border-bottom.pb-2.mb-3 Change History
     = render "model_history", model: @school