fix: Fixes various Hound issues for 2.0 (#370)

* fix: Fixes Hound issues (1/6)

* fix: Additional Hound issues

Author: cbaudouinjr

app/controllers/rsvps_controller.rb

@@ -65,7 +65,7 @@ def update
     bus_after_rsvp = @questionnaire.bus_list_id
     acc_status_after_rsvp = @questionnaire.acc_status
 
-    if bus != nil && (acc_status != acc_status_after_rsvp || bus != bus_after_rsvp) && @questionnaire.is_bus_captain == true
+    if !bus.nil? && (acc_status != acc_status_after_rsvp || bus != bus_after_rsvp) && @questionnaire.is_bus_captain == true
       @questionnaire.is_bus_captain = false
       directors = User.where(role: :director)
       directors.each do |user|

db/migrate/20200525234832_move_user_info_from_questionnaire_to_user_model.rb

@@ -1,13 +1,11 @@
 class MoveUserInfoFromQuestionnaireToUserModel < ActiveRecord::Migration[5.2]
-
   # See the "Hackathon Manager 2.0 Migration Guide"
   # for a more general description of what this migration does.
 
   # Effectively, we move the `first_name` and `last_name` columns
   # from the questionnares table to the users table (and model, for both).
 
   def up
-
     # Add the first/last name columns to the users table
     add_column :users, :first_name, :string
     add_column :users, :last_name,  :string
@@ -26,7 +24,7 @@ def up
       email_head   = u.email.partition('@').first
       u.first_name = email_head
       u.last_name  = email_head
-      u.save()
+      u.save
     end
 
     # Remove the first/last name columns from the questionnaires table
@@ -35,7 +33,6 @@ def up
   end
 
   def down
-
     # Add the first/last name columns back to the questionnaires table
     add_column :questionnaires, :first_name, :string
     add_column :questionnaires, :last_name,  :string
@@ -48,7 +45,7 @@ def down
     # and set both their first/last name to nil.
     User.all.each do |u|
       email_head = u.email.partition('@').first
-      if u.first_name == email_head and u.last_name == email_head
+      if u.first_name == email_head && u.last_name == email_head
         u.first_name = nil
         u.last_name  = nil
       end