fix(questionnaire): added phone number requirements (#283)

* fix(questionnaire): added phone number requirement

using a regex to require users to input a valid phone number and
stripped non numbers from the stored value with the exception of the
country code

* fix(questionnaire): edited callback to pass test

edit call back that removes non-numbers from phone number to pass
testing

* fix(questionnaire): edited test to fail with phone formatting

edited test to fail if the phone # formating is still there when saved
into the database. Also stopped exception for "+" as it was not
necessary.

* fix(questionnaire): fixed comment about phone number stripping

* fix: houndci formatting comments

* fix: earlier fix was incorrect. correct houndci fix

* fix(phone): implmented changed phone number regex for validation

implement suggested regex although made internation extention 3 instead
of 2 digits long for max length

* fix(questionnaire): added support for more international numbers

made the numbers regex more flexable to support more international
numbers such as in Nigeria with two digit area codes.

* Phone validation hit, remove duplicate check

Co-authored-by: Chris Baudouin, Jr <[email protected]>
Co-authored-by: Peter Kos <[email protected]>

Author: 3 people

app/assets/javascripts/validate.js

@@ -40,6 +40,15 @@ document.addEventListener('turbolinks:load', function() {
               }
             }
             break;
+          case 'phone':
+            if (value) {
+              var phoneReg = /^[\+]?[0-9]{0,3}[-\s\.]?[(]?[0-9]{1,3}[)]?[-\s\.]?[0-9]{1,3}[-\s\.]?[0-9]{4,6}$/;
+              if (!phoneReg.test(value)) {
+                notify(this, 'Please enter a valid phone number');
+                success = false;
+              }
+            }
+            break;
           case 'file-max-size':
             if (
               this.files &&

app/models/questionnaire.rb

@@ -138,6 +138,12 @@ def vcs_url=(value)
     super value
   end
 
+  def phone=(value)
+    # strips the string to just numbers for standardization
+    value = value.try(:tr, '^0-9', '')
+    super value
+  end
+
   def school
     School.find(school_id) if school_id
   end

app/views/questionnaires/_form.html.haml

@@ -10,7 +10,7 @@
           = markdown(HackathonConfig['disclaimer_message'])
 
       .form-inputs
-        = f.input :phone, label: "Phone number", input_html: { "data-validate" => "presence" }
+        = f.input :phone, label: "Phone number", input_html: { "data-validate" => ["presence", "phone"] }
         = f.input :date_of_birth, start_year: Date.today.year - 5, end_year: Date.today.year - 90, order: [:month, :day, :year], input_html: { "data-validate" => "presence" }
 
         = f.input :school_id, as: :school_selection, input_html: { "data-validate" => "presence" }

test/controllers/manage/questionnaires_controller_test.rb

@@ -390,7 +390,7 @@ class Manage::QuestionnairesControllerTest < ActionController::TestCase
       assert_equal @user.id, @questionnaire.checked_in_by_id
       assert_equal true, @questionnaire.agreement_accepted
       assert_equal true, @questionnaire.can_share_info
-      assert_equal "(123) 333-3333", @questionnaire.phone
+      assert_equal "1233333333", @questionnaire.phone
       assert_equal "[email protected]", @questionnaire.email
       assert_match /Checked in/, flash[:notice]
       assert_response :redirect