Enable a few more ESLint rules

Author: miorel

tools/adventure-pack/goodies/typescript/Number.isIntegerOrIntegerObject/index.test.ts

@@ -40,7 +40,7 @@ describe("Number.isIntegerOrIntegerObject", () => {
     expect(Number.isIntegerOrIntegerObject(true)).toBe(false);
     expect(Number.isIntegerOrIntegerObject(false)).toBe(false);
     expect(Number.isIntegerOrIntegerObject(Symbol("12"))).toBe(false);
-    expect(Number.isIntegerOrIntegerObject(Symbol())).toBe(false);
+    expect(Number.isIntegerOrIntegerObject(Symbol(undefined))).toBe(false);
     expect(Number.isIntegerOrIntegerObject({})).toBe(false);
     expect(Number.isIntegerOrIntegerObject([])).toBe(false);
     expect(Number.isIntegerOrIntegerObject([12])).toBe(false);

tools/adventure-pack/src/app/useMergedCode.ts

@@ -15,7 +15,7 @@ export function useMergedCode({
 
   useEffect(() => {
     if (goodies == null) {
-      return;
+      return undefined;
     }
 
     let isActive = true;

tools/adventure-pack/src/scripts/package-goodies/typescript/readGoodies.ts

@@ -10,9 +10,9 @@ import type { JavaScriptGoody } from "../../../app/parsers/javaScriptGoodyParser
 import type { TypeScriptGoody } from "../../../app/parsers/typeScriptGoodyParser";
 import { fillOutImportedByAndSortImports } from "../fillOutImportedByAndSortImports";
 import {
+  GOODIES_DIRECTORY,
   type TypeScriptGoodyBase,
   readBaseGoody,
-  GOODIES_DIRECTORY,
 } from "./readBaseGoody";
 import { transpile } from "./transpile";
 

tools/adventure-pack/src/scripts/package-goodies/typescript/transpile.ts

@@ -1,10 +1,10 @@
 import invariant from "invariant";
 import {
-  createScanner,
-  transpile as originalTranspile,
   LanguageVariant,
-  SyntaxKind,
   ScriptTarget,
+  SyntaxKind,
+  createScanner,
+  transpile as originalTranspile,
 } from "typescript";
 
 import { getRandomBytes } from "@code-chronicles/util";

tools/download-submissions/src/getFilenameForSubmission.ts

@@ -9,8 +9,9 @@ import type { TransformedSubmission } from "./transformSubmission";
 export function getFilenameForSubmission({
   id,
   lang,
-  timestamp,
+  // eslint-disable-next-line camelcase
   status_display,
+  timestamp,
 }: TransformedSubmission): string {
   const extension =
     LANGUAGE_TO_FILE_EXTENSION[
@@ -19,6 +20,7 @@ export function getFilenameForSubmission({
   const date = timestampToYearMonthDay(timestamp, "");
   const resultAbbreviation = nullthrows(
     SUBMISSION_STATUS_TO_ABBREVIATION[
+      // eslint-disable-next-line camelcase
       status_display as keyof typeof SUBMISSION_STATUS_TO_ABBREVIATION
     ],
   ).toLowerCase();

tools/download-submissions/src/transformSubmission.ts

@@ -28,6 +28,7 @@ export type TransformedSubmission = Omit<
 
 export function transformSubmission({
   code,
+  // eslint-disable-next-line camelcase
   compare_result,
   time: _,
   ...rest
@@ -40,6 +41,7 @@ export function transformSubmission({
     submission: {
       ...rest,
       sha512: sha512(code),
+      // eslint-disable-next-line camelcase
       compare_result: compare_result?.map(Number).join("") ?? null,
     },
   };

tools/eslint-config/eslint.config.js

@@ -27,12 +27,46 @@ const vanilla = {
         ignoreStringLiterals: true,
       },
     ],
+
+    "accessor-pairs": [
+      "error",
+      {
+        getWithoutSet: false,
+        setWithoutGet: true,
+        enforceForClassMembers: true,
+      },
+    ],
     "array-callback-return": [
       "error",
       { allowImplicit: false, checkForEach: true, allowVoid: false },
     ],
+    "arrow-body-style": [
+      "warn",
+      "as-needed",
+      { requireReturnForObjectLiteral: false },
+    ],
+    "block-scoped-var": "error",
+    camelcase: [
+      "warn",
+      {
+        properties: "always",
+        ignoreDestructuring: false,
+        ignoreImports: false,
+        ignoreGlobals: false,
+        allow: [],
+      },
+    ],
+    "class-methods-use-this": [
+      "warn",
+      { exceptMethods: [], enforceForClassFields: true },
+    ],
+    complexity: ["warn", { max: 20 }],
+    "consistent-return": ["error", { treatUndefinedAsUnspecified: false }],
+    "consistent-this": ["warn", "self"],
     "constructor-super": "error",
     curly: ["warn", "all"],
+    "default-case-last": "error",
+    eqeqeq: ["error", "always", { null: "never" }],
     "for-direction": "error",
     "getter-return": "error",
     "no-async-promise-executor": "error",
@@ -125,6 +159,9 @@ const vanilla = {
     "no-useless-assignment": "error",
     "no-useless-backreference": "error",
     "require-atomic-updates": "error",
+    "require-await": "error",
+    "require-yield": "error",
+    "symbol-description": "warn",
     "use-isnan": [
       "error",
       { enforceForSwitchCase: true, enforceForIndexOf: true },
@@ -138,12 +175,16 @@ const typescript = {
   files: ["**/*.ts", "**/*.tsx"],
   plugins: {
     ...vanilla.plugins,
-    "@typescript-eslint": typescriptEslintPlugin,
     "@stylistic/ts": stylisticPluginTs,
+    "@typescript-eslint": typescriptEslintPlugin,
   },
   rules: {
     ...vanilla.rules,
 
+    // In TypeScript files, use the TypeScript version of the rule.
+    "@stylistic/js/quotes": "off",
+    "@stylistic/ts/quotes": vanilla.rules["@stylistic/js/quotes"],
+
     // In TypeScript files, TypeScript itself should take care of this.
     "no-undef": "off",
 
@@ -156,10 +197,6 @@ const typescript = {
     // TODO: configure the additional options
     "@typescript-eslint/no-use-before-define":
       vanilla.rules["no-use-before-define"],
-
-    // In TypeScript files, use the TypeScript version of the rule.
-    "@stylistic/js/quotes": "off",
-    "@stylistic/ts/quotes": vanilla.rules["@stylistic/js/quotes"],
   },
 };
 

tools/leetcode-api/src/getSubmissionList.ts

@@ -32,12 +32,15 @@ const submissionParser = (() => {
   return z
     .object({
       id: positiveInt.transform(String),
+      // eslint-disable-next-line camelcase
       question_id: positiveInt,
       lang: trimmedNonEmptyString,
+      // eslint-disable-next-line camelcase
       lang_name: trimmedNonEmptyString,
       time: trimmedNonEmptyString.transform((s) => s.replace(/\u00a0/g, " ")),
       timestamp: int.nonnegative(),
       status: int,
+      // eslint-disable-next-line camelcase
       status_display: trimmedNonEmptyString,
       runtime: trimmedNonEmptyString,
       url: z
@@ -46,37 +49,56 @@ const submissionParser = (() => {
         .transform((value) =>
           new URL(value, "https://leetcode.com/").toString(),
         ),
+      // eslint-disable-next-line camelcase
       is_pending: trimmedNonEmptyString,
       title: trimmedNonEmptyString,
       memory: trimmedNonEmptyString,
       code: untrimmedNonEmptyString,
+      // eslint-disable-next-line camelcase
       compare_result: z
         .string()
         .regex(/^[01]*$/)
         .transform((value) => Array.from(value).map((c) => c === "1"))
         .nullable(),
+      // eslint-disable-next-line camelcase
       title_slug: z
         .string()
         .trim()
         .regex(/^[a-z0-9\-]+$/),
+      // eslint-disable-next-line camelcase
       has_notes: z.boolean(),
+      // eslint-disable-next-line camelcase
       flag_type: int,
     })
-    .transform(({ question_id, title, title_slug, ...rest }) => ({
-      ...rest,
-      question: {
-        questionFrontendId: question_id,
+    .transform(
+      ({
+        // eslint-disable-next-line camelcase
+        question_id,
         title,
-        titleSlug: title_slug,
-      },
-    }));
+        // eslint-disable-next-line camelcase
+        title_slug,
+        ...rest
+      }) => ({
+        ...rest,
+        question: {
+          // eslint-disable-next-line camelcase
+          questionFrontendId: question_id,
+          title,
+          // eslint-disable-next-line camelcase
+          titleSlug: title_slug,
+        },
+      }),
+    );
 })();
 
 export type Submission = z.infer<typeof submissionParser>;
 
 const submissionListParser = z.object({
+  // eslint-disable-next-line camelcase
   submissions_dump: z.array(submissionParser),
+  // eslint-disable-next-line camelcase
   has_next: z.boolean(),
+  // eslint-disable-next-line camelcase
   last_key: z.string(),
 });