Don't be overly clever in the implementation

Author: miorel

workspaces/adventure-pack/goodies/typescript/String.prototype.caesar/index.ts

@@ -10,11 +10,8 @@ declare global {
 }
 
 String.prototype.caesar = function (this: String, delta: number = 1): string {
-  return this.replaceAll(
-    /([a-z])|[A-Z]/g,
-    (letter: string, lower: string | undefined) => {
-      const offset = (lower == null ? "A" : "a").ord();
-      return ((letter.ord() - offset + delta).positiveMod(26) + offset).chr();
-    },
-  );
+  return this.replaceAll(/[a-z]/gi, (letter: string) => {
+    const offset = (letter >= "A" && letter <= "Z" ? "A" : "a").ord();
+    return ((letter.ord() - offset + delta).positiveMod(26) + offset).chr();
+  });
 };

workspaces/adventure-pack/src/app/__tests__/__snapshots__/equip-test.ts.snap

@@ -2408,8 +2408,8 @@ String.prototype.ord = function () {
 };
 
 String.prototype.caesar = function (delta = 1) {
-  return this.replaceAll(/([a-z])|[A-Z]/g, (letter, lower) => {
-    const offset = (lower == null ? "A" : "a").ord();
+  return this.replaceAll(/[a-z]/gi, (letter) => {
+    const offset = (letter >= "A" && letter <= "Z" ? "A" : "a").ord();
     return ((letter.ord() - offset + delta).positiveMod(26) + offset).chr();
   });
 };
@@ -5043,13 +5043,10 @@ String.prototype.ord = function (this: String): number {
 };
 
 String.prototype.caesar = function (this: String, delta: number = 1): string {
-  return this.replaceAll(
-    /([a-z])|[A-Z]/g,
-    (letter: string, lower: string | undefined) => {
-      const offset = (lower == null ? "A" : "a").ord();
-      return ((letter.ord() - offset + delta).positiveMod(26) + offset).chr();
-    },
-  );
+  return this.replaceAll(/[a-z]/gi, (letter: string) => {
+    const offset = (letter >= "A" && letter <= "Z" ? "A" : "a").ord();
+    return ((letter.ord() - offset + delta).positiveMod(26) + offset).chr();
+  });
 };
 
 /////////////////////////// END ADVENTURE PACK CODE ////////////////////////////"

workspaces/adventure-pack/src/app/__tests__/__snapshots__/render-test.ts.snap

@@ -1310,8 +1310,8 @@ import "Number.prototype.positiveMod";
 import "String.prototype.ord";
 
 String.prototype.caesar = function (delta = 1) {
-  return this.replaceAll(/([a-z])|[A-Z]/g, (letter, lower) => {
-    const offset = (lower == null ? "A" : "a").ord();
+  return this.replaceAll(/[a-z]/gi, (letter) => {
+    const offset = (letter >= "A" && letter <= "Z" ? "A" : "a").ord();
     return ((letter.ord() - offset + delta).positiveMod(26) + offset).chr();
   });
 };"
@@ -2869,13 +2869,10 @@ declare global {
 }
 
 String.prototype.caesar = function (this: String, delta: number = 1): string {
-  return this.replaceAll(
-    /([a-z])|[A-Z]/g,
-    (letter: string, lower: string | undefined) => {
-      const offset = (lower == null ? "A" : "a").ord();
-      return ((letter.ord() - offset + delta).positiveMod(26) + offset).chr();
-    },
-  );
+  return this.replaceAll(/[a-z]/gi, (letter: string) => {
+    const offset = (letter >= "A" && letter <= "Z" ? "A" : "a").ord();
+    return ((letter.ord() - offset + delta).positiveMod(26) + offset).chr();
+  });
 };"
 `;