Revert a bunch of things

Author: miorel

.github/workflows/run-tests.yml

@@ -5,12 +5,8 @@ on:
     types: [opened, synchronize]
 
 jobs:
-  run-tests:
-    strategy:
-      fail-fast: false
-      matrix:
-        os: [ubuntu-latest, windows-latest, macos-latest]
-    runs-on: ${{ matrix.os }}
+  lint:
+    runs-on: ubuntu-latest
 
     steps:
       - name: Check out repository

workspaces/util/src/execWithArgs.ts

@@ -17,18 +17,7 @@ export function execWithArgs(
 ): Promise<ExecWithArgsResult> {
   return new Promise((resolve, reject) => {
     const childProcess = spawn(command, args, {
-      // TODO: share code between this callsite and spawnWithSafeStdio
-
-      // Without a shell specified, many comands seem to fail to spawn on
-      // Windows. I verified that it's not a PATH issue. It seems like it's
-      // probably https://github.com/nodejs/node-v0.x-archive/issues/5841
-      ...(process.platform === "win32" && {
-        shell: "bash",
-        windowsVerbatimArguments: true,
-      }),
-
       ...options,
-
       stdio: ["ignore", "pipe", "pipe"],
     });
 

workspaces/util/src/readWorkspaces.ts

@@ -5,13 +5,11 @@ import { getLines } from "@code-chronicles/util/getLines";
 import { execWithArgsOrThrowOnNzec } from "@code-chronicles/util/execWithArgsOrThrowOnNzec";
 
 export async function readWorkspaces(): Promise<string[]> {
-  const yarnCommandResult = await execWithArgsOrThrowOnNzec(
-    "yarn",
-    ["workspaces", "list", "--json"],
-    { env: { ...process.env, YARN_ENABLE_HARDENED_MODE: "0" } },
-  );
-
-  console.log(yarnCommandResult);
+  const yarnCommandResult = await execWithArgsOrThrowOnNzec("yarn", [
+    "workspaces",
+    "list",
+    "--json",
+  ]);
 
   return [...getLines(yarnCommandResult.stdout)]
     .map((line) => assertIsObject(JSON.parse(line)))

workspaces/util/src/spawnWithSafeStdio.ts

@@ -1,31 +1,14 @@
 import process from "node:process";
 import { spawn, type SpawnOptions } from "node:child_process";
 
-// TODO: audit callsites since the behavior changed recently
+// TODO: audit callsites since the behavior is changing
 
 export function spawnWithSafeStdio(
   command: string,
   args: readonly string[],
   options?: SpawnOptions,
 ): Promise<void> {
   return new Promise((resolve, reject) => {
-    console.log({
-      command,
-      args,
-      options: {
-        // When using "inherit" mode, it sometimes broke the interaction with
-        // the actions/github-script@v7 GitHub Action, so we default to piping.
-        stdio: ["ignore", "pipe", "pipe"],
-
-        // Without a shell specified, many comands seem to fail to spawn on
-        // Windows. I verified that it's not a PATH issue. It seems like it's
-        // probably https://github.com/nodejs/node-v0.x-archive/issues/5841
-        ...(process.platform === "win32" && { shell: "bash" }),
-
-        ...options,
-      },
-    });
-
     const childProcess = spawn(command, args, {
       // When using "inherit" mode, it sometimes broke the interaction with
       // the actions/github-script@v7 GitHub Action, so we default to piping.
@@ -34,10 +17,7 @@ export function spawnWithSafeStdio(
       // Without a shell specified, many comands seem to fail to spawn on
       // Windows. I verified that it's not a PATH issue. It seems like it's
       // probably https://github.com/nodejs/node-v0.x-archive/issues/5841
-      ...(process.platform === "win32" && {
-        shell: "bash",
-        windowsVerbatimArguments: true,
-      }),
+      ...(process.platform === "win32" && { shell: options?.shell ?? "bash" }),
 
       ...options,
     });