Mostly cosmetic tweaks to a handful of tests and implementations (#436)

Author: miorel

workspaces/adventure-pack/goodies/kotlin/src/traverse_level_order/Main.kt

@@ -2,18 +2,18 @@ package traverse_level_order
 
 public data class TreeNode(val `val`: Int, var left: TreeNode? = null, var right: TreeNode? = null)
 
-public fun TreeNode?.traverseLevelOrder(): Sequence<Collection<TreeNode>> {
+public fun TreeNode?.traverseLevelOrder(): Sequence<List<TreeNode>> {
   if (this == null) {
     return sequenceOf()
   }
 
   var nodesAtLevel = listOf(this)
 
   return sequence {
-    while (nodesAtLevel.isNotEmpty()) {
+    do {
       yield(nodesAtLevel)
 
       nodesAtLevel = nodesAtLevel.flatMap { listOf(it.left, it.right) }.filterNotNull()
-    }
+    } while (nodesAtLevel.isNotEmpty())
   }
 }

workspaces/adventure-pack/goodies/kotlin/src/traverse_level_order/Test.kt

@@ -3,30 +3,29 @@ package traverse_level_order
 import kotlin.test.*
 
 internal class LevelOrderTraversalTest {
-
   @Test
-  fun itTraversesLevelOrderEmptyTree() {
-    val root: TreeNode? = null
+  fun traversesSimpleTree() {
+    val root =
+        TreeNode(
+            314,
+            TreeNode(159, TreeNode(265, TreeNode(35)), TreeNode(8979)),
+            TreeNode(323, TreeNode(846), TreeNode(26)))
     assertContentEquals(
-        root.traverseLevelOrder().flatMap { it }.map { it.`val` }.toList(), emptyList<Int>())
+        root.traverseLevelOrder().map { level -> level.map { it.`val` } }.toList(),
+        listOf(listOf(314), listOf(159, 323), listOf(265, 8979, 846, 26), listOf(35)))
   }
 
   @Test
-  fun itTraversesLevelOrderSingleNode() {
-    val root: TreeNode = TreeNode(0)
-    assertContentEquals(
-        root.traverseLevelOrder().flatMap { it }.map { it.`val` }.toList(), listOf<Int>(0))
+  fun traversesEmptyTree() {
+    val root: TreeNode? = null
+    assertContentEquals(root.traverseLevelOrder().toList(), emptyList())
   }
 
   @Test
-  fun itTraversesLevelOrderFullTree() {
-    val root: TreeNode =
-        TreeNode(
-            1,
-            TreeNode(2, TreeNode(4, TreeNode(8)), TreeNode(5)),
-            TreeNode(3, TreeNode(6), TreeNode(7)))
+  fun traversesSingleNode() {
+    val root = TreeNode(0)
     assertContentEquals(
-        root.traverseLevelOrder().flatMap { it }.map { it.`val` }.toList(),
-        listOf<Int>(1, 2, 3, 4, 5, 6, 7, 8))
+        root.traverseLevelOrder().map { level -> level.map { it.`val` } }.toList(),
+        listOf(listOf(0)))
   }
 }

workspaces/adventure-pack/goodies/python3/src/flatten/__init__.py

@@ -1,11 +1,10 @@
 from typing import Generator, TypeVar
 
 T = TypeVar("T")
+NestedList = T | list["NestedList"]
 
-nested_list = T | list["nested_list"]
 
-
-def flatten(self: nested_list) -> Generator[T, None, None]:
+def flatten(self: NestedList) -> Generator[T, None, None]:
     for i in self:
         if isinstance(i, list):
             yield from flatten(i)

workspaces/adventure-pack/goodies/python3/src/flatten/test.py

@@ -12,6 +12,5 @@ def test_flatten_random_types():
     dictionary = {"something": "something_else"}
     l = [["hi", -80, "c", 0.0], [[(3, 3), dictionary, 6], [5, 4, 3]], 2, 1, 0]
     flattened = list(flatten(l))
-    assert isinstance(l[0], list)
     expected = ["hi", -80, "c", 0.0, (3, 3), dictionary, 6, 5, 4, 3, 2, 1, 0]
     assert flattened == expected

workspaces/adventure-pack/goodies/python3/src/transpose_matrix/__init__.py

@@ -1,16 +1,14 @@
 from typing import TypeVar
 
-matrix_element = TypeVar("matrix_element")
+T = TypeVar("T")
 
 
-def transpose_matrix(
-    input: list[list[matrix_element]],
-) -> list[list[matrix_element]]:
+def transpose_matrix(input: list[list[T]]) -> list[list[T]]:
     r = len(input)
     c = len(input[0]) if r != 0 else 0
     if r == 0 or c == 0:
-        raise ValueError("Can't transpose a matrix that has a 0 dimension")
+        raise ValueError("Can't transpose a matrix that has a 0 dimension!")
     if any(len(row) != c for row in input):
-        raise ValueError("Matrix has rows of different lengths")
+        raise ValueError("Matrix has rows of different lengths!")
 
     return [list(row) for row in zip(*input)]

workspaces/adventure-pack/goodies/python3/src/transpose_matrix/test.py

@@ -1,4 +1,5 @@
 from . import *
+
 import pytest
 
 
@@ -13,33 +14,30 @@ def test_improper_input() -> None:
         transpose_matrix([[0], [0, 1]])
 
 
-def test_nonsymetric_transpose() -> None:
-    input_1 = [[0, 1, 2, 3], [4, 5, 6, 7], [8, 9, 10, 11]]
-    expected_1 = [[0, 4, 8], [1, 5, 9], [2, 6, 10], [3, 7, 11]]
-    input_2 = [
+def test_nonsymmetric_transpose() -> None:
+    matrix_1 = [[0, 1, 2, 3], [4, 5, 6, 7], [8, 9, 10, 11]]
+    transpose_1 = [[0, 4, 8], [1, 5, 9], [2, 6, 10], [3, 7, 11]]
+    assert transpose_matrix(matrix_1) == transpose_1
+
+    matrix_2 = [
         ["0", "1", "2"],
         ["3", "4", "5"],
         ["6", "7", "8"],
         ["9", "10", "11"],
     ]
-    expected_2 = [
+    transpose_2 = [
         ["0", "3", "6", "9"],
         ["1", "4", "7", "10"],
         ["2", "5", "8", "11"],
     ]
-    input_3 = [[3, 1, 4], [1, 5, 9], [2, 6, 5], [3, 5, 8]]
-    expected_3 = [[3, 1, 2, 3], [1, 5, 6, 5], [4, 9, 5, 8]]
-    actual_1 = transpose_matrix(input_1)
-    actual_2 = transpose_matrix(input_2)
-    actual_3 = transpose_matrix(input_3)
-    assert expected_1 == actual_1
-    assert expected_2 == actual_2
-    assert expected_3 == actual_3
-
-
-def test_symetric_transpose() -> None:
-    input_1 = [[0, 1, 2], [3, 4, 5], [6, 7, 8]]
-    expected = [[0, 3, 6], [1, 4, 7], [2, 5, 8]]
-    actual = transpose_matrix(input_1)
+    assert transpose_matrix(matrix_2) == transpose_2
 
-    assert expected == actual
+    matrix_3 = [[3, 1, 4], [1, 5, 9], [2, 6, 5], [3, 5, 8]]
+    transpose_3 = [[3, 1, 2, 3], [1, 5, 6, 5], [4, 9, 5, 8]]
+    assert transpose_matrix(matrix_3) == transpose_3
+
+
+def test_symmetric_transpose() -> None:
+    matrix = [[0, 1, 2], [3, 4, 5], [6, 7, 8]]
+    expected = [[0, 3, 6], [1, 4, 7], [2, 5, 8]]
+    assert transpose_matrix(matrix) == expected