merge

Author: dshemetov

R/new_epipredict_steps/layer_yeo_johnson.R

@@ -156,7 +156,7 @@ slather.layer_epi_YeoJohnson <- function(object, components, workflow, new_data,
     # c("lambda_ahead_1_case_rate", "lambda_ahead_7_case_rate").
     original_outcome_cols <- str_match(col_names, ".pred_ahead_\\d+_(.*)")[, 2]
     outcomes_wout_ahead <- str_match(names(components$mold$outcomes), "ahead_\\d+_(.*)")[,2]
-    if (all(original_outcome_cols %nin% outcomes_wout_ahead)) {
+    if (any(original_outcome_cols %nin% outcomes_wout_ahead)) {
       cli_abort("All columns specified in `...` must be outcome columns.", call = rlang::caller_env())
     }
 

R/new_epipredict_steps/step_yeo_johnson.R

@@ -237,7 +237,7 @@ get_lambdas_yj_table <- function(training, col_names, limits, num_unique, na_lam
   lambdas <- training %>%
     summarise(
       across(all_of(col_names), ~ estimate_yj(.x, limits, num_unique, na_rm)),
-      .by = epi_keys_checked
+      .by = all_of(epi_keys_checked)
     ) %>%
     rename_with(~ paste0(".lambda_", .x), -all_of(epi_keys_checked))
 

tests/testthat/test-yeo-johnson.R

@@ -1,6 +1,8 @@
 suppressPackageStartupMessages(source(here::here("R", "load_all.R")))
 
 test_that("Yeo-Johnson transformation inverts correctly", {
+  # Note that the special lambda values of 0 and 2 are covered by the tests
+  # below.
   expect_true(
     map_lgl(seq(-5, 5, 0.1), function(lambda) {
       map_lgl(seq(-10, 10, 0.1), \(x) abs(yj_inverse(yj_transform(x, lambda), lambda) - x) < 0.00001) %>% all()