Skip to content

Conversation

@krivard
Copy link
Contributor

@krivard krivard commented Oct 24, 2021

Don't open a database connection until you've downloaded the files when acquiring new covid_hosp data. This change was necessary for building the data patch to backfill #746 .

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@krivard krivard requested a review from chinandrew October 24, 2021 14:51
Copy link
Contributor

@chinandrew chinandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit::shipit::shipit:

@krivard krivard merged commit 767df60 into dev Oct 26, 2021
@krivard krivard deleted the krivard/robust-covidhosp-acquisition branch October 26, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants