Skip to content

Conversation

@sgratzl
Copy link
Member

@sgratzl sgratzl commented Aug 6, 2021

closes #671

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

adapts the covidcast endpoints to also support weekly signals

@sgratzl sgratzl self-assigned this Aug 6, 2021
@sgratzl sgratzl added api change affect the API and its responses enhancement labels Aug 6, 2021
@sgratzl sgratzl requested a review from krivard August 12, 2021 14:00
@sgratzl sgratzl marked this pull request as ready for review August 12, 2021 14:00
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible operator order bug, documentation nit, couple questions on whether we need to support mixed time-type sets of source+signal pairs

sgratzl and others added 2 commits August 17, 2021 13:20
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl sgratzl merged commit ff51a0a into dev Aug 17, 2021
@sgratzl sgratzl deleted the sgratzl/nchs-mortality-meta branch August 17, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change affect the API and its responses enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support nhs-mortality weekly signal in advanced covidcast endpoinst

3 participants