modified the bad code at function find_issue_specific_csv_files and add test

Author: zhuoran-Cheng16

src/acquisition/covidcast/csv_importer.py

@@ -88,11 +88,11 @@ def find_issue_specific_csv_files(scan_dir, glob=glob):
     logger = get_structured_logger('find_issue_specific_csv_files')
     for path in sorted(glob.glob(os.path.join(scan_dir, '*'))):
       issuedir_match = CsvImporter.PATTERN_ISSUE_DIR.match(path.lower())
-      if issuedir_match and os.path.isdir(path):
+      if issuedir_match and glob.glob(os.path.isdir(path)):
         issue_date_value = int(issuedir_match.group(2))
         issue_date = CsvImporter.is_sane_day(issue_date_value)
         if issue_date:
-          logger.info(event='processing csv files from issue', detail=issue_date, path)
+          logger.info(event='processing csv files from issue', detail=issue_date, file=path)
           yield from CsvImporter.find_csv_files(path, issue=(issue_date, epi.Week.fromdate(issue_date)), glob=glob)
         else:
           logger.warning(event='invalid issue directory day', detail=issue_date_value, file=path)

tests/acquisition/covidcast/test_csv_importer.py

@@ -41,23 +41,23 @@ def test_is_sane_week(self):
     self.assertFalse(CsvImporter.is_sane_week(202000))
     self.assertFalse(CsvImporter.is_sane_week(202054))
     self.assertFalse(CsvImporter.is_sane_week(20200418))
-  
+
   def test_find_issue_specific_csv_files(self):
       """Recursively explore and find issue specific CSV files."""
-
       path_prefix='prefix/to/the/data/'
       #valid day path
       issue_path='issue_20200408'
       glob_issue_path = path_prefix + issue_path
-      glob_file_path = path_prefix + issue_path + '/valid/20200408_nation_sig.csv'
+      glob_file_path = path_prefix + issue_path + '/ght/20200408_state_rawsearch.csv'
       mock_glob = MagicMock()
-      mock_glob.glob.side_effect = ([glob_issue_path], [glob_file_path])
-      issuedir_match = CsvImporter.PATTERN_ISSUE_DIR.match(glob_issue_path.lower())
-      issue_date_value = int(issuedir_match.group(2))
+      mock_glob.glob.side_effect = ([glob_issue_path], [glob_file_path], [glob_file_path])
 
       #check if the day is a valid issue day.
+      issuedir_match = CsvImporter.PATTERN_ISSUE_DIR.match(glob_issue_path.lower())
+      issue_date_value = int(issuedir_match.group(2))
+  
       self.assertTrue(CsvImporter.is_sane_day(issue_date_value))
- 
+
       found = set(CsvImporter.find_issue_specific_csv_files(path_prefix, glob=mock_glob))
       self.assertTrue(len(found)>0)