TEMPORARY TABLE is evil

in practice, we will probably not see issues with this unless we get some insanely large file to process, but with recent issues, i think this prudent.

Author: melange396

src/acquisition/covidcast/database.py

@@ -108,7 +108,7 @@ def insert_or_update_batch(self, cc_rows, batch_size=2**20, commit_partial=False
 
     # TODO: this heavily copypastas src/ddl/covidcast.sql -- theres got to be a better way
     create_tmp_table_sql = f'''
-      CREATE TEMPORARY TABLE `{tmp_table_name}` (
+      CREATE TABLE `{tmp_table_name}` (
         `source` varchar(32) NOT NULL,
         `signal` varchar(64) NOT NULL,
         `time_type` varchar(12) NOT NULL,
@@ -129,7 +129,7 @@ def insert_or_update_batch(self, cc_rows, batch_size=2**20, commit_partial=False
     '''
 
     truncate_tmp_table_sql = f'TRUNCATE TABLE {tmp_table_name};'
-    drop_tmp_table_sql = f'DROP TEMPORARY TABLE {tmp_table_name}'
+    drop_tmp_table_sql = f'DROP TABLE {tmp_table_name}'
 
     insert_into_tmp_sql = f'''
       INSERT INTO `{tmp_table_name}`