diff --git a/sir_complainsalot/delphi_sir_complainsalot/run.py b/sir_complainsalot/delphi_sir_complainsalot/run.py index 32341bb6d..46c5af010 100644 --- a/sir_complainsalot/delphi_sir_complainsalot/run.py +++ b/sir_complainsalot/delphi_sir_complainsalot/run.py @@ -37,14 +37,6 @@ def run_module(): params["sources"], params.get("grace", 0), LOGGER)) if len(complaints) > 0: - for complaint in complaints: - LOGGER.critical(event="signal out of SLA", - message=complaint.message, - data_source=complaint.data_source, - signal=complaint.signal, - geo_types=complaint.geo_types, - last_updated=complaint.last_updated.strftime("%Y-%m-%d")) - report_complaints(complaints, slack_notifier) elapsed_time_in_seconds = round(time.time() - start_time, 2) @@ -60,12 +52,12 @@ def split_complaints(complaints, n=49): def report_complaints(all_complaints, slack_notifier): """Post complaints to Slack.""" if not slack_notifier: - LOGGER.info("(dry-run)") + print("(dry-run)") return for complaints in split_complaints(all_complaints): blocks = format_complaints_aggregated_by_source(complaints) - LOGGER.info(f"blocks: {len(blocks)}") + print(f"blocks: {len(blocks)}") slack_notifier.post_message(blocks) def get_maintainers_block(complaints): @@ -108,6 +100,11 @@ def message_for_source(complaint): signal=complaint.signal, geo_types=", ".join(complaint.geo_types)) + LOGGER.critical(event="Signal out of SLA", + message=message, + data_source=source, + signal_and_geo_types=signal_and_geo_types) + blocks.extend([ { "type": "divider"