test lp_solver selection logic

Author: nmdefries

backfill_corrections/delphiBackfillCorrection/unit-tests/testthat/params-glpk_direct.json.template

@@ -0,0 +1,4 @@
+{
+  "input_dir": "./test.temp",
+  "lp_solver": "glpk"
+}

backfill_corrections/delphiBackfillCorrection/unit-tests/testthat/params-grb.json.template

@@ -0,0 +1,9 @@
+{
+  "input_dir": "./test.temp",
+  "lp_solver": "gurobi",
+  "gurobi": {
+    "GRB_LICENSEID": "1",
+    "GRB_WLSACCESSID": "2",
+    "GRB_WLSSECRET": "3"
+  }
+}

backfill_corrections/delphiBackfillCorrection/unit-tests/testthat/params-grb_noparams.json.template

@@ -0,0 +1,4 @@
+{
+  "input_dir": "./test.temp",
+  "lp_solver": "gurobi"
+}

backfill_corrections/delphiBackfillCorrection/unit-tests/testthat/params-grb_notallparams.json.template

@@ -0,0 +1,5 @@
+{
+  "input_dir": "./test.temp",
+  "lp_solver": "gurobi",
+  "gurobi": {"GRB_WLSACCESSID": ""}
+}

backfill_corrections/delphiBackfillCorrection/unit-tests/testthat/test-utils.R

@@ -81,9 +81,11 @@ test_that("testing read parameters", {
   # Create input file
   path = "test.temp"
   create_dir_not_exist(path)
-  expect_silent(params <- read_params(path = "params-test.json",
+  expect_warning(params <- read_params(path = "params-test.json",
                                       template_path = "params-test.json.template",
-                                      train_models = TRUE, make_predictions = TRUE))
+                                      train_models = TRUE, make_predictions = TRUE),
+                 "gurobi solver was requested but license information was not available"
+  )
   unlink(path, recursive = TRUE)
 
 
@@ -125,7 +127,7 @@ test_that("testing read parameters", {
 
   expect_true(all(params$taus == TAUS))
   expect_true(params$lambda == LAMBDA)
-  expect_true(params$lp_solver == LP_SOLVER)
+  expect_true(params$lp_solver == "glpk")
   expect_true(params$lag_pad == LAG_PAD)
 
   expect_true(params$num_col == "num")
@@ -148,6 +150,44 @@ test_that("testing read parameters", {
   expect_silent(file.remove("params-test.json"))
 })
 
+test_that("lp_solver selection works", {
+  # GLPK selected explicitly.
+  path = "test.temp"
+  create_dir_not_exist(path)
+  expect_silent(params <- read_params(path = "params-glpk_direct.json",
+                                      template_path = "params-glpk_direct.json.template",
+                                      train_models = TRUE, make_predictions = TRUE))
+  expect_true(params$lp_solver == "glpk")
+  expect_silent(file.remove("params-glpk_direct.json"))
+
+  # gurobi selected explicitly, but without gurobi params subsection
+  expect_warning(params <- read_params(path = "params-grb_noparams.json",
+                                      template_path = "params-grb_noparams.json.template",
+                                      train_models = TRUE, make_predictions = TRUE),
+                 "gurobi solver was requested but license information was not available"
+  )
+  expect_true(params$lp_solver == "glpk")
+  expect_silent(file.remove("params-grb_noparams.json"))
+
+  # gurobi selected explicitly, with gurobi params subsection, but without license information
+  expect_warning(params <- read_params(path = "params-grb_notallparams.json",
+                                      template_path = "params-grb_notallparams.json.template",
+                                      train_models = TRUE, make_predictions = TRUE),
+                 "gurobi solver was requested but license information was not available"
+  )
+  expect_true(params$lp_solver == "glpk")
+  expect_silent(file.remove("params-grb_notallparams.json"))
+
+  # gurobi selected explicitly
+  expect_silent(params <- read_params(path = "params-grb.json",
+                                      template_path = "params-grb.json.template",
+                                      train_models = TRUE, make_predictions = TRUE))
+  expect_true(params$lp_solver == "gurobi")
+  expect_silent(file.remove("params-grb.json"))
+
+  unlink(path, recursive = TRUE)
+})
+
 test_that("validity_checks alerts appropriately", {
   time_value = as.Date(c("2022-01-01", "2022-01-02", "2022-01-03"))
   issue_date = as.Date(c("2022-01-05", "2022-01-05", "2022-01-05"))