Skip to content
This repository was archived by the owner on Sep 27, 2019. It is now read-only.

Conversation

@pervazea
Copy link
Contributor

Also update cmake to use c++11

@coveralls
Copy link

coveralls commented Apr 19, 2018

Coverage Status

Coverage decreased (-0.01%) to 77.267% when pulling 6352488 on pervazea:jenkins into fd4a31c on cmu-db:master.

@pervazea pervazea requested review from pmenon and tcm-marcel April 19, 2018 18:51
@pmenon
Copy link
Member

pmenon commented Apr 19, 2018

@pervazea Why do we need -Wno-c++14-compat now?

Update: Spoke with @pervazea offline. Turns out we have some custom allocation code that doesn't work in C++14, hence the C++14 compatibility warning suppression. Note: We'll have to revisit this if we choose to move to C++14.

LGTM.

@pervazea
Copy link
Contributor Author

Same intermittent memory leak failure on the query_logger_test. Otherwise passed on Jenkins.
I'm going to re-run the Jenkins build, just to see how reproducible the query_logger_test issue is.

@pmenon
Copy link
Member

pmenon commented Apr 19, 2018

Actually, @pervazea do we also want to build and run the test suite for macOS on Travis?

@pervazea
Copy link
Contributor Author

Test suite for macOS on Travis, sure. I'll do it as a follow up though. Get this in and unblock progress.

@pervazea pervazea merged commit 87efb13 into cmu-db:master Apr 19, 2018
mtunique pushed a commit to mtunique/peloton that referenced this pull request Apr 16, 2019
* Move to gcc5

* Compilation fix (don't warn about c++14)

* Remove gcc 4.8 builds from Travis
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants