Skip to content

Commit f1bd5df

Browse files
authored
Merge pull request #25 from clue-labs/php8.4
Run tests on PHP 8.4 and update test environment
2 parents d686670 + b84f093 commit f1bd5df

File tree

4 files changed

+15
-19
lines changed

4 files changed

+15
-19
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@ on:
77
jobs:
88
PHPUnit:
99
name: PHPUnit (PHP ${{ matrix.php }})
10-
runs-on: ubuntu-22.04
10+
runs-on: ubuntu-24.04
1111
strategy:
1212
matrix:
1313
php:
14+
- 8.4
1415
- 8.3
1516
- 8.2
1617
- 8.1
@@ -38,7 +39,7 @@ jobs:
3839

3940
PHPUnit-hhvm:
4041
name: PHPUnit (HHVM)
41-
runs-on: ubuntu-22.04
42+
runs-on: ubuntu-24.04
4243
continue-on-error: true
4344
steps:
4445
- uses: actions/checkout@v4

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ composer install
183183
To run the test suite, go to the project root and run:
184184

185185
```bash
186-
php vendor/bin/phpunit
186+
vendor/bin/phpunit
187187
```
188188

189189
## License

composer.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,6 @@
1010
"email": "[email protected]"
1111
}
1212
],
13-
"autoload": {
14-
"psr-4": {
15-
"Clue\\React\\Multicast\\": "src/"
16-
}
17-
},
18-
"autoload-dev": {
19-
"psr-4": {
20-
"Clue\\Tests\\React\\Multicast\\": "tests/"
21-
}
22-
},
2313
"require": {
2414
"php": ">=5.3",
2515
"react/datagram": "^1.10",
@@ -31,5 +21,15 @@
3121
},
3222
"suggest": {
3323
"ext-sockets": "Requires PHP 5.4+ and the low level socket API for listening on multicast addresses (socket options to send IGMP announcements)"
24+
},
25+
"autoload": {
26+
"psr-4": {
27+
"Clue\\React\\Multicast\\": "src/"
28+
}
29+
},
30+
"autoload-dev": {
31+
"psr-4": {
32+
"Clue\\Tests\\React\\Multicast\\": "tests/"
33+
}
3434
}
3535
}

src/Factory.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,7 @@ class Factory
2222
* This value SHOULD NOT be given unless you're sure you want to explicitly use a
2323
* given event loop instance.
2424
*
25-
* ```php
26-
* $loop = React\EventLoop\Factory::create();
27-
* $factory = new Factory($loop);
28-
* ```
29-
*
30-
* @param LoopInterface $loop
25+
* @param ?LoopInterface $loop
3126
*/
3227
public function __construct($loop = null)
3328
{

0 commit comments

Comments
 (0)