Skip to content

Commit 743c865

Browse files
authored
Merge pull request #15 from SimonFrings/tests
Clean up test suite, add .gitattributes to exclude dev files from exports and run tests on PHP 7.4 and simplify test matrix
2 parents e151291 + 317d474 commit 743c865

File tree

6 files changed

+32
-26
lines changed

6 files changed

+32
-26
lines changed

.gitattributes

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
/.gitattributes export-ignore
2+
/.gitignore export-ignore
3+
/.travis.yml export-ignore
4+
/examples/ export-ignore
5+
/phpunit.xml.dist export-ignore
6+
/tests/ export-ignore

.travis.yml

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,23 @@
11
language: php
22

3-
php:
4-
# - 5.3 # requires old distro, see below
5-
- 5.4
6-
- 5.5
7-
- 5.6
8-
- 7.0
9-
- 7.1
10-
- 7.2
11-
- hhvm # ignore errors, see below
12-
13-
# lock distro so future defaults will not break the build
3+
# lock distro so new future defaults will not break the build
144
dist: trusty
155

166
matrix:
177
include:
188
- php: 5.3
199
dist: precise
10+
- php: 5.4
11+
- php: 5.5
12+
- php: 5.6
13+
- php: 7.0
14+
- php: 7.1
15+
- php: 7.2
16+
- php: 7.3
17+
- php: 7.4
18+
- php: hhvm-3.18
2019
allow_failures:
21-
- php: hhvm
20+
- php: hhvm-3.18
2221

2322
sudo: false
2423

composer.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,17 @@
1313
"autoload": {
1414
"psr-4": { "Clue\\React\\Multicast\\": "src/" }
1515
},
16+
"autoload-dev": {
17+
"psr-4": { "Clue\\Tests\\React\\Multicast\\": "tests/" }
18+
},
1619
"require": {
1720
"php": ">=5.3",
1821
"react/event-loop": "^1.0 || ^0.5 || ^0.4 || ^0.3",
1922
"react/datagram": "~1.0"
2023
},
2124
"require-dev": {
2225
"clue/hexdump": "0.2.*",
23-
"phpunit/phpunit": "^6.0 || ^5.7 || ^4.8.35"
26+
"phpunit/phpunit": "^9.0 ||^6.0 || ^5.7 || ^4.8.35"
2427
},
2528
"suggest": {
2629
"ext-sockets": "Requires PHP 5.4+ and the low level socket API for listening on multicast addresses (socket options to send IGMP announcements)"

phpunit.xml.dist

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22

3-
<phpunit bootstrap="tests/bootstrap.php"
4-
colors="true"
5-
convertErrorsToExceptions="true"
6-
convertNoticesToExceptions="true"
7-
convertWarningsToExceptions="true"
8-
>
3+
<phpunit bootstrap="vendor/autoload.php" colors="true">
94
<testsuites>
105
<testsuite name="Multicast React Test Suite">
116
<directory>./tests/</directory>

tests/FunctionalTest.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
namespace Clue\Tests\React\Multicast;
4+
35
use Clue\React\Multicast\Factory;
46

57
class FunctionalTest extends TestCase
@@ -9,9 +11,12 @@ class FunctionalTest extends TestCase
911

1012
private $address = '224.224.244.244:2244';
1113

12-
public function setUp()
14+
/**
15+
* @before
16+
*/
17+
public function setUpMocks()
1318
{
14-
$this->loop = React\EventLoop\Factory::create();
19+
$this->loop = \React\EventLoop\Factory::create();
1520
$this->factory = new Factory($this->loop);
1621
}
1722

@@ -31,7 +36,7 @@ public function testMultipleReceivers()
3136
{
3237
try {
3338
$receiver1 = $this->factory->createReceiver($this->address);
34-
} catch (BadMethodCallException $e) {
39+
} catch (\BadMethodCallException $e) {
3540
$this->markTestSkipped('No multicast support');
3641
}
3742

tests/bootstrap.php renamed to tests/TestCase.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
<?php
22

3-
require __DIR__ . '/../vendor/autoload.php';
3+
namespace Clue\Tests\React\Multicast;
44

5-
error_reporting(-1);
6-
7-
class TestCase extends PHPUnit\Framework\TestCase
5+
class TestCase extends \PHPUnit\Framework\TestCase
86
{
97
protected function expectCallableOnce()
108
{

0 commit comments

Comments
 (0)