From a34bd00fb4d9f86c4bf21ec1da5c358f61ac78e5 Mon Sep 17 00:00:00 2001 From: Webster Mudge Date: Tue, 5 Aug 2025 14:05:04 -0400 Subject: [PATCH] Deprecate common role Signed-off-by: Webster Mudge --- .ansible-lint-ignore | 12 +++-------- meta/runtime.yml | 4 ++++ roles/common/README.md | 3 +++ roles/common/meta/main.yml | 43 ------------------------------------- roles/common/tasks/main.yml | 6 ++++++ 5 files changed, 16 insertions(+), 52 deletions(-) delete mode 100644 roles/common/meta/main.yml diff --git a/.ansible-lint-ignore b/.ansible-lint-ignore index d57eb5fe..0f8bcc66 100644 --- a/.ansible-lint-ignore +++ b/.ansible-lint-ignore @@ -15,20 +15,14 @@ roles/auto_repo_mirror/defaults/main.yml var-naming[no-role-prefix] skip roles/auto_repo_mirror/tasks/inject.yml ignore-errors skip roles/auto_repo_mirror/tasks/inject.yml yaml[line-length] skip -roles/auto_repo_mirror/tasks/inject.yml fqcn[action-core]s skip -roles/auto_repo_mirror/tasks/inject.yml risky-file-permissions skip roles/auto_repo_mirror/tasks/inject.yml fqcn[action-core] skip +roles/auto_repo_mirror/tasks/inject.yml risky-file-permissions skip roles/auto_repo_mirror/tasks/inject.yml jinja[spacing][/] skip -roles/auto_repo_mirror/tasks/inject.yml jinja[spacing][/] skip -roles/auto_repo_mirror/tasks/inject.yml yaml[line-length] skip -roles/auto_repo_mirror/tasks/inject.yml:104: yaml[line-length] skip -roles/auto_repo_mirror/tasks/inject.yml:134: jinja[spacing][/] skip -roles/auto_repo_mirror/tasks/parse_definition_for_mirror_targets.yml yaml[line-length] skip roles/auto_repo_mirror/tasks/parse_definition_for_mirror_targets.yml yaml[line-length] skip -roles/auto_repo_mirror/tasks/parse_definition_for_mirror_targets.yml:104: yaml[line-length] skip -roles/auto_repo_mirror/tasks/populate_from_upstream.yml risky-file-permissions skip roles/auto_repo_mirror/tasks/populate_from_upstream.yml risky-file-permissions skip roles/auto_repo_mirror/tasks/populate_from_upstream.yml ignore-errors skip roles/auto_repo_mirror/tasks/update_mirror_cache.yml yaml[line-length] skip roles/auto_repo_mirror/tasks/update_mirror_cache.yml risky-file-permissions skip roles/auto_repo_mirror/vars/main.yml var-naming[no-role-prefix] skip +roles/common/defaults/main.yml jinja[spacing][/] skip +roles/common/defaults/main.yml yaml[line-length] skip diff --git a/meta/runtime.yml b/meta/runtime.yml index c5670153..63bb4756 100644 --- a/meta/runtime.yml +++ b/meta/runtime.yml @@ -37,3 +37,7 @@ plugin_routing: deprecation: removal_version: 4.0.0 warning_text: Role, auto_repo_mirror, is not longer supported. + common: + deprecation: + removal_version: 4.0.0 + warning_text: Role, common, is not longer supported. diff --git a/roles/common/README.md b/roles/common/README.md index f9583815..73e0684d 100644 --- a/roles/common/README.md +++ b/roles/common/README.md @@ -15,3 +15,6 @@ --> # common + +> [!WARNING] +> No longer supported and will be removed in version 4.0.0 diff --git a/roles/common/meta/main.yml b/roles/common/meta/main.yml deleted file mode 100644 index ac050d70..00000000 --- a/roles/common/meta/main.yml +++ /dev/null @@ -1,43 +0,0 @@ ---- -# Copyright 2023 Cloudera, Inc. All Rights Reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -galaxy_info: - role_name: platform - namespace: cloudera - author: Webster Mudge (wmudge@cloudera.com) - description: > - Shared configuration variables managed by role dependency. - company: Cloudera - license: Apache-2.0 - - min_ansible_version: 2.10 - - platforms: - - name: Debian - versions: all - - name: Fedora - versions: all - - name: GenericLinux - versions: all - - name: MacOSX - versions: all - - name: Ubuntu - versions: all - - galaxy_tags: - - cloudera - - cdp - -dependencies: [] diff --git a/roles/common/tasks/main.yml b/roles/common/tasks/main.yml index e3cf5040..7e247d46 100644 --- a/roles/common/tasks/main.yml +++ b/roles/common/tasks/main.yml @@ -11,3 +11,9 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. + +- name: Deprecation warning + run_once: true + cloudera.exe.deprecation: + msg: "Role, {{ ansible_role_name }}, is no longer supported." + version: 4.0.0