Relocate role plugins (#245)

* Move cm_prepare_db module
* Move jdk_facts module
* Update reference to cm_prepare_db module
* Update reference to jdk_facts and alternatives modules

Signed-off-by: Webster Mudge <[email protected]>

Author: wmudge

roles/cm_server/library/cm_prepare_db.py renamed to plugins/modules/cm_prepare_db.py

@@ -1,3 +1,4 @@
+#!/usr/bin/python
 # -*- coding: utf-8 -*-
 
 # Copyright 2024 Cloudera, Inc.

roles/prereq_jdk/library/jdk_facts.py renamed to plugins/modules/jdk_facts.py

@@ -60,15 +60,16 @@
       ansible.builtin.package_facts:
 
     - name: Prepare Cloudera Manager server external database
-      cm_prepare_db:
-        script: "{{
-          (
-            ansible_facts.packages['cloudera-manager-server'] |
-            map(attribute='version') |
-            first is version('6.0.0', '>=')
-          ) |
-          ternary('/opt/cloudera/cm/schema/scm_prepare_database.sh', '/usr/share/cmf/schema/scm_prepare_database.sh')
-        }}"
+      cloudera.exe.cm_prepare_db:
+        script: >
+          {{
+            (
+              ansible_facts.packages['cloudera-manager-server'] |
+              map(attribute='version') |
+              first is version('6.0.0', '>=')
+            ) |
+            ternary('/opt/cloudera/cm/schema/scm_prepare_database.sh', '/usr/share/cmf/schema/scm_prepare_database.sh')
+          }}
         type: "{{ cloudera_manager_database_type }}"
         host: "{{ cloudera_manager_database_host }}"
         port: "{{ cloudera_manager_database_port }}"

roles/cm_server/tasks/main.yml

@@ -45,7 +45,7 @@
       register: __jdk_home
 
     - name: Create alternatives symlink for Cloudera Java binary
-      ansible.builtin.alternatives:
+      community.general.alternatives:
         name: java
         link: /usr/bin/java
         path: "{{ __jdk_home.files[0].path }}/bin/java"
@@ -59,7 +59,7 @@
       when: __jdk_home.matched
 
 - name: Discover installed JDK details
-  jdk_facts:
+  cloudera.exe.jdk_facts:
 
 - name: Enable JCE policy for JDK 9 or lower
   when: ansible_facts.jdk["version"] is not version("10.0.0", ">=", version_type="loose")
@@ -99,10 +99,15 @@
   when: >
     ansible_facts.jdk["provider"] == "openjdk" and
     (
-      (ansible_facts.jdk["version"] is version("1.8", ">=", version_type="loose") and ansible_facts.jdk["version"] is version("1.9", "<=", version_type="loose") and
-    ansible_facts.jdk["update"]|int >= 242)
+      (
+        ansible_facts.jdk["version"] is version("1.8", ">=", version_type="loose") and
+        ansible_facts.jdk["version"] is version("1.9", "<=", version_type="loose") and
+        ansible_facts.jdk["update"] | int >= 242
+      )
       or
-      (ansible_facts.jdk["version"] is version("11.0.6", ">=", version_type="semver"))
+      (
+        ansible_facts.jdk["version"] is version("11.0.6", ">=", version_type="semver")
+      )
     )
 
 # https://docs.cloudera.com/cdp-private-cloud-base/7.1.9/installation/topics/cdpdc-manually-installing-openjdk.html