Skip to content

Commit 7e888fa

Browse files
committed
Address comments in PR
Signed-off-by: Christopher Perro <[email protected]>
1 parent 25c97e9 commit 7e888fa

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

docs/configuration.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,7 @@ globals:
259259
dynamic_inventory:
260260
vm:
261261
count:
262+
os:
262263
force_teardown:
263264
gcloud_credential_file:
264265
infra_deployment_engine:

roles/common/defaults/main.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,6 @@ common__aws_datalake_admin_suffix: "{{ env.aws.role.label.datalake_admin
117117
common__aws_idbroker_role_name: "{{ env.aws.role.name.idbroker | default([common__namespace, common__aws_idbroker_suffix, common__aws_role_suffix] | join('-')) }}"
118118
common__aws_idbroker_suffix: "{{ env.aws.role.label.idbroker | default(common__idbroker_suffix) }}"
119119

120-
121-
common__aws_vpc_id: "{{ infra.aws.vpc.existing.vpc_id | default('') }}"
122-
common__aws_public_subnet_ids: "{{ infra.aws.vpc.existing.public_subnet_ids | default([]) }}"
123-
common__aws_private_subnet_ids: "{{ infra.aws.vpc.existing.private_subnet_ids | default([]) }}"
124-
125120
# Azure Infra
126121
common__azure_storage_name: "{{ infra.azure.storage.name | default(common__storage_name | replace('-','')) }}"
127122

roles/runtime/tasks/initialize_teardown.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,17 @@
3030
name: "{{ run__env_name }}"
3131
register: run__df_env_info
3232

33+
- name: Discover CDP Data Warehouse cluster
34+
cloudera.cloud.dw_cluster_info:
35+
env: "{{ run__env_name }}"
36+
register: __dw_list
37+
3338
- name: Discover CDP Data Warehouse deployments
3439
when:
3540
- run__include_dw
3641
- not run__force_teardown | bool or not run__dw_force_delete | bool
42+
- __dw_list.clusters | length > 0
3743
block:
38-
- name: Discover CDP Data Warehouse cluster
39-
cloudera.cloud.dw_cluster_info:
40-
env: "{{ run__env_name }}"
41-
register: __dw_list
42-
4344
- name: Initialize CDP Data Warehouse cluster id
4445
ansible.builtin.set_fact:
4546
__dw_cluster_id: "{{ __dw_list.clusters | map(attribute='id') | first | default(omit) }}"

0 commit comments

Comments
 (0)