Update include_role statements to use the full role name within the Collection as a best practice (#10) (#11)

Fixes #9

Signed-off-by: Daniel Chaffelson

Co-authored-by: Dan Chaffelson <[email protected]>

Author: 2 people

roles/cloudera_manager/external_auth/tasks/main.yml

@@ -21,7 +21,7 @@
 
 - name: Set Cloudera Manager external auth configs
   include_role:
-    name: cloudera_manager/config
+    name: cloudera.cluster.cloudera_manager.config
   vars:
     api_config_keys_uppercase: True
     api_configs: "{{ lookup('template', 'external_auth_configs.j2') | from_yaml }}"

roles/config/cluster/kts/tasks/main.yml

@@ -16,7 +16,7 @@
 
 - name: Retrieve repository metadata
   include_role:
-    name: deployment/repometa
+    name: cloudera.cluster.deployment.repometa
   vars:
     repositories: "{{ cluster.repositories | default({}) }}"
 

roles/deployment/cluster/tasks/create_base.yml

@@ -16,11 +16,11 @@
 
 - name: Generate complete base cluster configs
   include_role:
-    name: config/cluster/base
+    name: cloudera.cluster.config.cluster.base
 
 - name: Create databases and users
   include_role:
-    name: deployment/databases
+    name: cloudera.cluster.deployment.databases
   vars:
     services: "{{ cluster.services | default({}) }}"
 

roles/deployment/cluster/tasks/create_kts.yml

@@ -16,7 +16,7 @@
 
 - name: Generate complete kts cluster configs
   include_role:
-    name: config/cluster/kts
+    name: cloudera.cluster.config.cluster.kts
 
 - name: Generate cluster template file
   template:

roles/deployment/cluster/tasks/main.yml

@@ -20,7 +20,7 @@
 
 - name: Apply "all hosts" configs
   include_role:
-    name: cloudera_manager/config
+    name: cloudera.cluster.cloudera_manager.config
   vars:
     api_config_keys_uppercase: False
     api_config_endpoint: cm/allHosts/config

roles/deployment/services/kms/tasks/create_kms.yml

@@ -75,7 +75,7 @@
 
 - name: Generate KMS configs
   include_role:
-    name: config/services/kms
+    name: cloudera.cluster.config.services.kms
 
 - name: Create KMS service
   cloudera.cluster.cm_api:

roles/teardown/tasks/main.yml

@@ -77,7 +77,7 @@
 
 - name: Remove Clusters from Cloudera Manager (compute)
   include_role:
-    name: operations/delete_cluster
+    name: cloudera.cluster.operations.delete_cluster
   vars:
     stop_cluster_before_delete: true
     cluster: "{{ default_cluster_compute | combine(_cluster) }}"
@@ -95,7 +95,7 @@
 
 - name: Remove Clusters from Cloudera Manager (base)
   include_role:
-    name: operations/delete_cluster
+    name: cloudera.cluster.operations.delete_cluster
   vars:
     stop_cluster_before_delete: true
     cluster: "{{ default_cluster_base | combine(_cluster) }}"
@@ -113,7 +113,7 @@
 
 - name: Remove Clusters from Cloudera Manager (kts)
   include_role:
-    name: operations/delete_cluster
+    name: cloudera.cluster.operations.delete_cluster
   vars:
     stop_cluster_before_delete: true
     cluster: "{{ default_cluster_kts | combine(_cluster) }}"
@@ -132,7 +132,7 @@
 # delete the cms from cm if we are not tearing cm down
 - name: Remove CMS from Cloudera Manager
   import_role:
-    name: operations/delete_cms
+    name: cloudera.cluster.operations.delete_cms
   vars:
     stop_cms_before_delete: true
   run_once: true

roles/teardown/tasks/teardown_cdsw.yml

@@ -16,7 +16,7 @@
 
 - name: Generate merged configs (base)
   include_role:
-    name: config/cluster/base
+    name: cloudera.cluster.config.cluster.base
 
 - name: Stop the CDSW node
   shell: /opt/cloudera/parcels/CDSW/scripts/cdsw-stop-node.sh

roles/teardown/tasks/teardown_cluster.yml

@@ -16,12 +16,12 @@
 
 - name: Generate merged configs (base, compute)
   include_role:
-    name: config/cluster/base
+    name: cloudera.cluster.config.cluster.base
   when: cluster.type | default('base') in ['base', 'compute']
 
 - name: Generate merged configs (kts)
   include_role:
-    name: config/cluster/kts
+    name: cloudera.cluster.config.cluster.kts
   when: cluster.type | default('base') == 'kts'
 
 - name: Remove cluster service directories (base, compute)

roles/teardown/tasks/teardown_cms.yml

@@ -16,7 +16,7 @@
 
 - name: Generate merged configs
   include_role:
-    name: config/services/mgmt
+    name: cloudera.cluster.config.services.mgmt
 
 - name: Delete service database
   include_tasks: teardown_database.yml