From af3dde4ebb173e77ff6e08e187bd1b8db39b475e Mon Sep 17 00:00:00 2001 From: Jim Enright Date: Sat, 6 Sep 2025 11:37:46 +0100 Subject: [PATCH 1/4] Remove tls alias for verify_tls Signed-off-by: Jim Enright --- plugins/module_utils/cdp_common.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/module_utils/cdp_common.py b/plugins/module_utils/cdp_common.py index 8af350a..50f4403 100644 --- a/plugins/module_utils/cdp_common.py +++ b/plugins/module_utils/cdp_common.py @@ -47,7 +47,7 @@ def _impl(self, *args, **kwargs): def __init__(self, module): # Set common parameters self.module = module - self.tls = self._get_param("verify_tls", False) + self.verify_tls = self._get_param("verify_tls", False) self.debug = self._get_param("debug", False) self.strict = self._get_param("strict", False) self.agent_header = self._get_param("agent_header", "ClouderaFoundry") @@ -61,7 +61,7 @@ def __init__(self, module): # Client Wrapper self.cdpy = Cdpy( debug=self.debug, - tls_verify=self.tls, + tls_verify=self.verify_tls, strict_errors=self.strict, error_handler=self._cdp_module_throw_error, warning_handler=self._cdp_module_throw_warning, @@ -103,7 +103,7 @@ def argument_spec(**spec): """Default Ansible Module spec values for convenience""" return dict( **spec, - verify_tls=dict(required=False, type="bool", default=True, aliases=["tls"]), + verify_tls=dict(required=False, type="bool", default=True), debug=dict( required=False, type="bool", From c638c44559677c8803ec501e49c67cf7564ae209 Mon Sep 17 00:00:00 2001 From: Jim Enright Date: Mon, 8 Sep 2025 16:52:12 +0100 Subject: [PATCH 2/4] Add verify_api_tls as alias for verify_tls argument Signed-off-by: Jim Enright --- plugins/module_utils/cdp_common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/module_utils/cdp_common.py b/plugins/module_utils/cdp_common.py index 50f4403..01158b8 100644 --- a/plugins/module_utils/cdp_common.py +++ b/plugins/module_utils/cdp_common.py @@ -103,7 +103,7 @@ def argument_spec(**spec): """Default Ansible Module spec values for convenience""" return dict( **spec, - verify_tls=dict(required=False, type="bool", default=True), + verify_tls=dict(required=False, type="bool", default=True, aliases=["verify_api_tls"]), debug=dict( required=False, type="bool", From 43503ab274aecf567deaae9e40aa9089d66235af Mon Sep 17 00:00:00 2001 From: Jim Enright Date: Mon, 8 Sep 2025 17:01:48 +0100 Subject: [PATCH 3/4] Fix lint issues Signed-off-by: Jim Enright --- plugins/module_utils/cdp_common.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/module_utils/cdp_common.py b/plugins/module_utils/cdp_common.py index 01158b8..2f22069 100644 --- a/plugins/module_utils/cdp_common.py +++ b/plugins/module_utils/cdp_common.py @@ -103,7 +103,9 @@ def argument_spec(**spec): """Default Ansible Module spec values for convenience""" return dict( **spec, - verify_tls=dict(required=False, type="bool", default=True, aliases=["verify_api_tls"]), + verify_tls=dict( + required=False, type="bool", default=True, aliases=["verify_api_tls"] + ), debug=dict( required=False, type="bool", From 13e19c235ff46f434c921df7e14e038a91ad1c61 Mon Sep 17 00:00:00 2001 From: Jim Enright Date: Mon, 8 Sep 2025 17:05:25 +0100 Subject: [PATCH 4/4] Fix lint issues Signed-off-by: Jim Enright --- plugins/module_utils/cdp_common.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/plugins/module_utils/cdp_common.py b/plugins/module_utils/cdp_common.py index 2f22069..105a239 100644 --- a/plugins/module_utils/cdp_common.py +++ b/plugins/module_utils/cdp_common.py @@ -104,7 +104,10 @@ def argument_spec(**spec): return dict( **spec, verify_tls=dict( - required=False, type="bool", default=True, aliases=["verify_api_tls"] + required=False, + type="bool", + default=True, + aliases=["verify_api_tls"], ), debug=dict( required=False,