[Feature] Support Laravel 5.8 (#312)

Adds support for Laravel 5.8, which is a non-breaking change.

Author: lindyhopchris

.travis.yml

@@ -28,6 +28,10 @@ matrix:
     env:
     - LARAVEL_VERSION=5.7.*
     - PHPUNIT_VERSION=^7.0
+  - php: 7.2
+    env:
+      - LARAVEL_VERSION=5.8.*
+      - PHPUNIT_VERSION=^7.0
   - php: 7.3
     env:
     - LARAVEL_VERSION=5.5.*
@@ -40,6 +44,10 @@ matrix:
     env:
     - LARAVEL_VERSION=5.7.*
     - PHPUNIT_VERSION=^7.0
+  - php: 7.3
+    env:
+      - LARAVEL_VERSION=5.8.*
+      - PHPUNIT_VERSION=^7.5
 
 install:
 - composer require "laravel/framework:${LARAVEL_VERSION}" --no-update -n

CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file. This projec
 
 ## Unreleased
 
+### Added
+- Package now supports Laravel 5.8.
+
 ### Fixed
 - [#302](https://github.com/cloudcreativity/laravel-json-api/issues/302)
 Reject resource objects sent in relationships, as the spec defines that only resource identifiers

README.md

@@ -60,6 +60,7 @@ A demo application is available at [here](https://github.com/cloudcreativity/dem
 
 | Laravel | This Package | EOL? |
 | --- | --- | --- |
+| 5.8.* | `dev-laravel-5.8` | - |
 | 5.7.* | `1.0.0-rc.2` | - |
 | 5.6.* | `1.0.0-rc.2` | - |
 | 5.5.* | `1.0.0-rc.2` | - |

composer.json

@@ -25,24 +25,24 @@
         "php": "^7.1",
         "ext-json": "*",
         "cloudcreativity/utils-object": "^1.0",
-        "illuminate/console": "5.5.*|5.6.*|5.7.*",
-        "illuminate/contracts": "5.5.*|5.6.*|5.7.*",
-        "illuminate/database": "5.5.*|5.6.*|5.7.*",
-        "illuminate/filesystem": "5.5.*|5.6.*|5.7.*",
-        "illuminate/http": "5.5.*|5.6.*|5.7.*",
-        "illuminate/pagination": "5.5.*|5.6.*|5.7.*",
-        "illuminate/support": "5.5.*|5.6.*|5.7.*",
+        "illuminate/console": "5.5.*|5.6.*|5.7.*|5.8.*",
+        "illuminate/contracts": "5.5.*|5.6.*|5.7.*|5.8.*",
+        "illuminate/database": "5.5.*|5.6.*|5.7.*|5.8.*",
+        "illuminate/filesystem": "5.5.*|5.6.*|5.7.*|5.8.*",
+        "illuminate/http": "5.5.*|5.6.*|5.7.*|5.8.*",
+        "illuminate/pagination": "5.5.*|5.6.*|5.7.*|5.8.*",
+        "illuminate/support": "5.5.*|5.6.*|5.7.*|5.8.*",
         "neomerx/json-api": "^1.0.3",
         "ramsey/uuid": "^3.0",
         "symfony/psr-http-message-bridge": "^1.0",
         "zendframework/zend-diactoros": "^1.3"
     },
     "require-dev": {
         "ext-sqlite3": "*",
-        "cloudcreativity/json-api-testing": "1.0.0-rc.1",
+        "cloudcreativity/json-api-testing": "^1.0.0",
         "guzzlehttp/guzzle": "^6.3",
         "mockery/mockery": "^1.1",
-        "orchestra/testbench": "3.5.*|3.6.*|3.7.*",
+        "orchestra/testbench": "3.5.*|3.6.*|3.7.*|3.8.*",
         "phpunit/phpunit": "^6.0|^7.0"
     },
     "suggest": {

src/Schema/CreatesEloquentIdentities.php

@@ -56,14 +56,24 @@ protected function createBelongsToIdentity(Model $model, $relationshipKey)
             ));
         }
 
-        $id = $model->{$relation->getForeignKey()};
+        // support Laravel 5.8
+        $foreignKey = method_exists($relation, 'getForeignKeyName') ?
+            $relation->getForeignKeyName() :
+            $relation->getForeignKey();
+
+        $id = $model->{$foreignKey};
 
         if (is_null($id)) {
             return null;
         }
 
+        // support Laravel 5.8
+        $ownerKey = method_exists($relation, 'getOwnerKeyName') ?
+            $relation->getOwnerKeyName() :
+            $relation->getOwnerKey();
+
         $related = $relation->getRelated()->replicate();
-        $related->{$relation->getOwnerKey()} = $id;
+        $related->{$ownerKey} = $id;
 
         return $related;
     }

src/Validation/Validator.php

@@ -18,6 +18,7 @@
 namespace CloudCreativity\LaravelJsonApi\Validation;
 
 use CloudCreativity\LaravelJsonApi\Contracts\Validation\ValidatorInterface;
+use CloudCreativity\LaravelJsonApi\Exceptions\RuntimeException;
 use Illuminate\Contracts\Validation\Validator as ValidatorContract;
 use Neomerx\JsonApi\Exceptions\ErrorCollection;
 
@@ -69,6 +70,20 @@ public function validate()
         return $this->validator->validate();
     }
 
+
+    /**
+     * @inheritdoc
+     */
+    public function validated()
+    {
+        // @TODO remove when only supporting Laravel >=5.8
+        if (!method_exists($this->validator, 'validated')) {
+            throw new RuntimeException('Not supported until Laravel 5.8');
+        }
+
+        return $this->validator->validated();
+    }
+
     /**
      * @inheritDoc
      */

tests/dummy/tests/Feature/Avatars/TestCase.php

@@ -33,7 +33,7 @@ abstract class TestCase extends BaseTestCase
     /**
      * @return void
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         parent::setUp();
         Storage::fake('local');

tests/dummy/tests/TestCase.php

@@ -40,7 +40,7 @@ abstract class TestCase extends BaseTestCase
     /**
      * @return void
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         parent::setUp();
         $this->artisan('migrate');

tests/lib/Integration/Auth/AuthorizerTest.php

@@ -37,7 +37,7 @@ class AuthorizerTest extends TestCase
     /**
      * @return void
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         parent::setUp();
 

tests/lib/Integration/Auth/ControllerAuthorizationTest.php

@@ -36,7 +36,7 @@ class ControllerAuthorizationTest extends TestCase
     /**
      * @return void
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         parent::setUp();