Skip to content

Commit ec24e28

Browse files
committed
Merge branch 'hotfix/1.3.1'
2 parents c0c1a45 + d09ad5f commit ec24e28

File tree

5 files changed

+40
-36
lines changed

5 files changed

+40
-36
lines changed

.travis.yml

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,42 +4,43 @@ sudo: false
44

55
matrix:
66
include:
7-
- php: 7.1
7+
- php: "7.1"
88
env:
99
- LARAVEL_VERSION=5.5.*
1010
- PHPUNIT_VERSION=^6.5
11-
- php: 7.1
11+
- php: "7.1"
1212
env:
1313
- LARAVEL_VERSION=5.6.*
1414
- PHPUNIT_VERSION=^7.0
15-
- php: 7.1
15+
- php: "7.1"
1616
env:
1717
- LARAVEL_VERSION=5.7.*
1818
- PHPUNIT_VERSION=^7.0
19-
- php: 7.2
19+
- php: "7.2"
2020
env:
2121
- LARAVEL_VERSION=5.5.*
2222
- PHPUNIT_VERSION=^6.5
23-
- php: 7.2
23+
- php: "7.2"
2424
env:
2525
- LARAVEL_VERSION=5.8.*
2626
- PHPUNIT_VERSION=^7.0
27-
- php: 7.2
28-
env:
29-
- LARAVEL_VERSION=5.9.*
30-
- PHPUNIT_VERSION=^7.0
31-
- php: 7.3
27+
- php: "7.3"
3228
env:
3329
- LARAVEL_VERSION=5.5.*
3430
- PHPUNIT_VERSION=^6.5
35-
- php: 7.3
31+
- php: "7.3"
3632
env:
3733
- LARAVEL_VERSION=5.8.*
3834
- PHPUNIT_VERSION=^7.0
39-
- php: 7.3
35+
- php: "7.3"
36+
env:
37+
- LARAVEL_VERSION=^6.0
38+
- PHPUNIT_VERSION=^8.0
39+
allow_failures:
40+
- php: "7.3"
4041
env:
41-
- LARAVEL_VERSION=5.9.*
42-
- PHPUNIT_VERSION=^7.5
42+
- LARAVEL_VERSION=^6.0
43+
- PHPUNIT_VERSION=^8.0
4344

4445
install:
4546
- composer require "laravel/framework:${LARAVEL_VERSION}" --no-update -n

CHANGELOG.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,14 @@
22
All notable changes to this project will be documented in this file. This project adheres to
33
[Semantic Versioning](http://semver.org/) and [this changelog format](http://keepachangelog.com/).
44

5-
## [1.3.0] - 2019-07-24
5+
## [1.3.1] - 2019-08-19
6+
7+
### Fixed
8+
- Updated Travis config for Laravel `5.9` being renamed `6.0`.
9+
- [#400](https://github.com/cloudcreativity/laravel-json-api/pull/400)
10+
Fix overridden variable in error translator.
611

7-
Package now supports Laravel 5.9.
12+
## [1.3.0] - 2019-07-24
813

914
### Added
1015
- [#352](https://github.com/cloudcreativity/laravel-json-api/issues/352)

README.md

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,13 @@ A demo application is available at [here](https://github.com/cloudcreativity/dem
6060

6161
## Laravel Versions
6262

63-
| Laravel | This Package | EOL? |
64-
| --- | --- | --- |
65-
| 5.9.* | `^1.3` | - |
66-
| 5.8.* | `^1.0` | - |
67-
| 5.7.* | `^1.0` | - |
68-
| 5.6.* | `^1.0` | - |
69-
| 5.5.* | `^1.0` | - |
70-
| 5.4.* | `1.0.0-beta.3` | EOL |
63+
| Laravel | This Package |
64+
| --- | --- |
65+
| `^6.0` | `^1.4` |
66+
| `5.8.*` | `^1.0` |
67+
| `5.7.*` | `^1.0` |
68+
| `5.6.*` | `^1.0` |
69+
| `5.5.*` | `^1.0` |
7170

7271
Make sure you consult the [Upgrade Guide](http://laravel-json-api.readthedocs.io/en/latest/upgrade/)
7372
when upgrading.

composer.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@
2525
"php": "^7.1",
2626
"ext-json": "*",
2727
"cloudcreativity/utils-object": "^1.0",
28-
"illuminate/console": "5.5.*|5.6.*|5.7.*|5.8.*|5.9.*",
29-
"illuminate/contracts": "5.5.*|5.6.*|5.7.*|5.8.*|5.9.*",
30-
"illuminate/database": "5.5.*|5.6.*|5.7.*|5.8.*|5.9.*",
31-
"illuminate/filesystem": "5.5.*|5.6.*|5.7.*|5.8.*|5.9.*",
32-
"illuminate/http": "5.5.*|5.6.*|5.7.*|5.8.*|5.9.*",
33-
"illuminate/pagination": "5.5.*|5.6.*|5.7.*|5.8.*|5.9.*",
34-
"illuminate/support": "5.5.*|5.6.*|5.7.*|5.8.*|5.9.*",
28+
"illuminate/console": "^5.5|^6.0",
29+
"illuminate/contracts": "^5.5|^6.0",
30+
"illuminate/database": "^5.5|^6.0",
31+
"illuminate/filesystem": "^5.5|^6.0",
32+
"illuminate/http": "^5.5|^6.0",
33+
"illuminate/pagination": "^5.5|^6.0",
34+
"illuminate/support": "^5.5|^6.0",
3535
"neomerx/json-api": "^1.0.3",
3636
"ramsey/uuid": "^3.0",
3737
"symfony/psr-http-message-bridge": "^1.0",
@@ -43,8 +43,8 @@
4343
"composer/semver": "^1.5",
4444
"guzzlehttp/guzzle": "^6.3",
4545
"mockery/mockery": "^1.1",
46-
"orchestra/testbench": "3.5.*|3.6.*|3.7.*|3.8.*|3.9.*",
47-
"phpunit/phpunit": "^6.0|^7.0"
46+
"orchestra/testbench": "^3.5|^4.0",
47+
"phpunit/phpunit": "^6.0|^7.0|^8.0"
4848
},
4949
"suggest": {
5050
"cloudcreativity/json-api-testing": "Required to use the test helpers."

src/Validation/ErrorTranslator.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -416,10 +416,9 @@ public function failedValidator(ValidatorContract $validator, \Closure $closure
416416
$failures = $this->createValidationFailures($failed[$key] ?? []);
417417

418418
foreach ($messages as $detail) {
419-
$failed = $failures->shift() ?: [];
420-
421419
if ($closure) {
422-
$errors->add($this->call($closure, $key, $detail, $failed));
420+
$currentFailure = $failures->shift() ?: [];
421+
$errors->add($this->call($closure, $key, $detail, $currentFailure));
423422
continue;
424423
}
425424

0 commit comments

Comments
 (0)