#60 Fix PHP 8.1 restrictions

Author: njoubert-cleverage

src/Entity/ProcessSchedule.php

@@ -87,7 +87,12 @@ public function setContext(array $context): void
         $this->context = $context;
     }
 
-    public function getNextExecution(): null
+    /**
+     * PHP 8.1 Fatal error: Null can not be used as a standalone type.
+     *
+     * @phpstan-ignore missingType.return
+     */
+    public function getNextExecution()
     {
         return null;
     }

src/EventSubscriber/ProcessEventSubscriber.php

@@ -22,12 +22,15 @@
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Uid\Uuid;
 
-final readonly class ProcessEventSubscriber implements EventSubscriberInterface
+/**
+ * PHP 8.2 : Replace by readonly class.
+ */
+final class ProcessEventSubscriber implements EventSubscriberInterface
 {
     public function __construct(
-        private ProcessHandler $processHandler,
-        private DoctrineProcessHandler $doctrineProcessHandler,
-        private ProcessExecutionManager $processExecutionManager,
+        private readonly ProcessHandler $processHandler,
+        private readonly DoctrineProcessHandler $doctrineProcessHandler,
+        private readonly ProcessExecutionManager $processExecutionManager,
     ) {
     }
 

src/Http/Model/HttpProcessExecution.php

@@ -20,18 +20,21 @@
 use Symfony\Component\Validator\Constraints\Sequentially;
 use Symfony\Component\Validator\Constraints\Type;
 
-final readonly class HttpProcessExecution
+/**
+ * PHP 8.2 : Replace by readonly class.
+ */
+final class HttpProcessExecution
 {
     /**
      * @param string|array<string|int, mixed> $context
      */
     public function __construct(
         #[Sequentially(constraints: [new NotNull(message: 'Process code is required.'), new IsValidProcessCode()])]
-        public ?string $code = null,
-        public ?string $input = null,
+        public readonly ?string $code = null,
+        public readonly ?string $input = null,
         #[AtLeastOneOf(constraints: [new Json(), new Type('array')])]
-        public string|array $context = [],
-        public bool $queue = true,
+        public readonly string|array $context = [],
+        public readonly bool $queue = true,
     ) {
     }
 }

src/Http/ValueResolver/HttpProcessExecuteValueResolver.php

@@ -22,10 +22,13 @@
 use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadata;
 use Symfony\Component\Serializer\SerializerInterface;
 
+/**
+ * PHP 8.2 : Replace by readonly class.
+ */
 #[AsTargetedValueResolver('http_process_execution')]
-readonly class HttpProcessExecuteValueResolver implements ValueResolverInterface
+class HttpProcessExecuteValueResolver implements ValueResolverInterface
 {
-    public function __construct(private string $storageDir, private SerializerInterface $serializer)
+    public function __construct(private readonly string $storageDir, private readonly SerializerInterface $serializer)
     {
     }
 

src/Http/ValueResolver/ProcessConfigurationValueResolver.php

@@ -20,10 +20,13 @@
 use Symfony\Component\HttpKernel\Controller\ValueResolverInterface;
 use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadata;
 
+/**
+ * PHP 8.2 : Replace by readonly class.
+ */
 #[AsTargetedValueResolver('process')]
-readonly class ProcessConfigurationValueResolver implements ValueResolverInterface
+class ProcessConfigurationValueResolver implements ValueResolverInterface
 {
-    public function __construct(private ProcessConfigurationRegistry $registry)
+    public function __construct(private readonly ProcessConfigurationRegistry $registry)
     {
     }
 

src/Manager/ProcessConfigurationsManager.php

@@ -20,6 +20,9 @@
 use Symfony\Component\OptionsResolver\OptionsResolver;
 use Symfony\Component\Validator\Constraint;
 
+/**
+ * PHP 8.2 : Replace by readonly class.
+ */
 /**
  * @phpstan-type UiOptions array{
  *      'source': ?string,
@@ -32,9 +35,9 @@
  *      'default': array{'input': mixed, 'context': array{array{'key': 'int|text', 'value':'int|text'}}}
  *  }
  */
-final readonly class ProcessConfigurationsManager
+final class ProcessConfigurationsManager
 {
-    public function __construct(private ProcessConfigurationRegistry $registry)
+    public function __construct(private readonly ProcessConfigurationRegistry $registry)
     {
     }
 

src/Message/CronProcessMessage.php

@@ -15,9 +15,12 @@
 
 use CleverAge\UiProcessBundle\Entity\ProcessSchedule;
 
-final readonly class CronProcessMessage
+/**
+ * PHP 8.2 : Replace by readonly class.
+ */
+final class CronProcessMessage
 {
-    public function __construct(public ProcessSchedule $processSchedule)
+    public function __construct(public readonly ProcessSchedule $processSchedule)
     {
     }
 }

src/Message/CronProcessMessageHandler.php

@@ -16,10 +16,13 @@
 use Symfony\Component\Messenger\Attribute\AsMessageHandler;
 use Symfony\Component\Messenger\MessageBusInterface;
 
+/**
+ * PHP 8.2 : Replace by readonly class.
+ */
 #[AsMessageHandler]
-final readonly class CronProcessMessageHandler
+final class CronProcessMessageHandler
 {
-    public function __construct(private MessageBusInterface $bus)
+    public function __construct(private readonly MessageBusInterface $bus)
     {
     }
 

src/Message/ProcessExecuteHandler.php

@@ -17,10 +17,13 @@
 use CleverAge\UiProcessBundle\Monolog\Handler\ProcessHandler;
 use Symfony\Component\Messenger\Attribute\AsMessageHandler;
 
+/**
+ * PHP 8.2 : Replace by readonly class.
+ */
 #[AsMessageHandler]
-readonly class ProcessExecuteHandler
+class ProcessExecuteHandler
 {
-    public function __construct(private ProcessManager $manager, private readonly ProcessHandler $processHandler)
+    public function __construct(private readonly ProcessManager $manager, private readonly ProcessHandler $processHandler)
     {
     }
 

src/Scheduler/CronScheduler.php

@@ -22,12 +22,15 @@
 use Symfony\Component\Scheduler\ScheduleProviderInterface;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 
-readonly class CronScheduler implements ScheduleProviderInterface
+/**
+ * PHP 8.2 : Replace by readonly class.
+ */
+class CronScheduler implements ScheduleProviderInterface
 {
     public function __construct(
-        private ProcessScheduleRepository $repository,
-        private ValidatorInterface $validator,
-        private LoggerInterface $logger,
+        private readonly ProcessScheduleRepository $repository,
+        private readonly ValidatorInterface $validator,
+        private readonly LoggerInterface $logger,
     ) {
     }